This is an archive of the discontinued LLVM Phabricator instance.

tsan: disable bench_threads.cpp on aarch64
ClosedPublic

Authored by dvyukov on Nov 16 2021, 5:47 AM.

Details

Summary

The new test started failing on bots with:

CHECK failed: tsan_rtl.cpp:327 "((addr + size)) <= ((TraceMemEnd()))"

(0xf06200e03010, 0xf06200000000) (tid=4073872)

https://lab.llvm.org/buildbot#builders/179/builds/1761

This is a latent bug in aarch64 virtual address space layout,
there is not enough address space to fit traces for all threads.
But since the trace space is going away with the new tsan runtime
(D112603), disable the test.

Diff Detail

Event Timeline

dvyukov created this revision.Nov 16 2021, 5:47 AM
dvyukov requested review of this revision.Nov 16 2021, 5:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2021, 5:47 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Nov 16 2021, 7:37 AM
melver added inline comments.
compiler-rt/test/tsan/bench_threads.cpp
9

So the test can later be re-enabled for aarch64, right?

If so, maybe add a TODO so it's not forgotten.

This revision is now accepted and ready to land.Nov 16 2021, 7:37 AM
dvyukov marked an inline comment as done.Nov 16 2021, 7:52 AM
This revision was landed with ongoing or failed builds.Nov 16 2021, 7:53 AM
This revision was automatically updated to reflect the committed changes.