This is an archive of the discontinued LLVM Phabricator instance.

Differential D113950

[libcxx] CI: only build native target for bootstrapping-build
ClosedPublic

Authored by mizvekov on Nov 15 2021, 3:35 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG35f798d05d51: [libcxx] CI: only build native target for bootstrapping-build
Summary

Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>

Diff Detail

Event Timeline

mizvekov created this revision.Nov 15 2021, 3:35 PM
Herald added a subscriber: arichardson. · View Herald TranscriptNov 15 2021, 3:35 PM
mizvekov requested review of this revision.Nov 15 2021, 3:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2021, 3:35 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
mizvekov added a reviewer: ldionne.Nov 15 2021, 4:32 PM
Harbormaster completed remote builds in B134376: Diff 387427.Nov 15 2021, 4:37 PM
mizvekov added a comment.Nov 15 2021, 5:23 PM

Rough estimate of improvement:

Number of source files built: 3610 -> 2589
Runtime: 24m -> 21m

ldionne accepted this revision.Nov 16 2021, 6:19 AM

Thanks for the improvement!

libcxx/utils/ci/run-buildbot
479

What is the difference between Native and host?

This revision is now accepted and ready to land.Nov 16 2021, 6:19 AM
mizvekov added a comment.Nov 16 2021, 8:17 AM

Thanks for the review!

libcxx/utils/ci/run-buildbot
479

You can see at llvm/cmake/config-ix.cmake:497 that Native and host are just synonyms:

foreach (NATIVE_KEYWORD host Native)
  list(FIND LLVM_TARGETS_TO_BUILD ${NATIVE_KEYWORD} idx)
  if( NOT idx LESS 0 )
    list(REMOVE_AT LLVM_TARGETS_TO_BUILD ${idx})
    list(APPEND LLVM_TARGETS_TO_BUILD ${LLVM_NATIVE_ARCH})
    list(REMOVE_DUPLICATES LLVM_TARGETS_TO_BUILD)
  endif()
endforeach()
Closed by commit rG35f798d05d51: [libcxx] CI: only build native target for bootstrapping-build (authored by mizvekov). · Explain WhyNov 16 2021, 8:22 AM
This revision was automatically updated to reflect the committed changes.
mizvekov added a commit: rG35f798d05d51: [libcxx] CI: only build native target for bootstrapping-build.

Revision Contents

PathSize
libcxx/
utils/
ci/
1 line

Diff 387427

libcxx/utils/ci/run-buildbot

Show First 20 Lines • Show All 470 Lines • ▼ Show 20 Lines ${CMAKE} \
-S "${MONOREPO_ROOT}/llvm" \ -S "${MONOREPO_ROOT}/llvm" \
-B "${BUILD_DIR}" \ -B "${BUILD_DIR}" \
-GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \ -GNinja -DCMAKE_MAKE_PROGRAM="${NINJA}" \
-DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}" \ -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}" \
-DLLVM_ENABLE_PROJECTS="clang" \ -DLLVM_ENABLE_PROJECTS="clang" \
-DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \ -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
-DLLVM_RUNTIME_TARGETS="$(c++ --print-target-triple)" \ -DLLVM_RUNTIME_TARGETS="$(c++ --print-target-triple)" \
-DLLVM_TARGETS_TO_BUILD="host" \
ldionneUnsubmitted
Not Done
ReplyInline Actions

What is the difference between Native and host?

ldionne: What is the difference between `Native` and `host`?
mizvekovAuthorUnsubmitted
Done
ReplyInline Actions

You can see at llvm/cmake/config-ix.cmake:497 that Native and host are just synonyms:

foreach (NATIVE_KEYWORD host Native)
  list(FIND LLVM_TARGETS_TO_BUILD ${NATIVE_KEYWORD} idx)
  if( NOT idx LESS 0 )
    list(REMOVE_AT LLVM_TARGETS_TO_BUILD ${idx})
    list(APPEND LLVM_TARGETS_TO_BUILD ${LLVM_NATIVE_ARCH})
    list(REMOVE_DUPLICATES LLVM_TARGETS_TO_BUILD)
  endif()
endforeach()
mizvekov: You can see at `llvm/cmake/config-ix.cmake:497` that Native and host are just synonyms: ```…
-DRUNTIMES_BUILD_ALLOW_DARWIN=ON \ -DRUNTIMES_BUILD_ALLOW_DARWIN=ON \
-DLLVM_ENABLE_ASSERTIONS=ON \ -DLLVM_ENABLE_ASSERTIONS=ON \
-C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-modules.cmake" \ -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-modules.cmake" \
-DLIBCXX_TEST_CONFIG="llvm-libc++-shared.cfg.in" \ -DLIBCXX_TEST_CONFIG="llvm-libc++-shared.cfg.in" \
-DLIBUNWIND_TEST_CONFIG="llvm-libunwind-shared.cfg.in" -DLIBUNWIND_TEST_CONFIG="llvm-libunwind-shared.cfg.in"
echo "+++ Running the libc++ and libc++abi tests" echo "+++ Running the libc++ and libc++abi tests"
${NINJA} -C "${BUILD_DIR}" check-runtimes ${NINJA} -C "${BUILD_DIR}" check-runtimes
▲ Show 20 Lines • Show All 155 Lines • Show Last 20 Lines