This is an archive of the discontinued LLVM Phabricator instance.

Differential D113869

[VE][Target] Fix a problem caused by efa896e
AbandonedPublic

Authored by kaz7 on Nov 14 2021, 6:11 PM.

Details

Reviewers
simoll
k-ishizaka
Summary

Previous NFC commit breaked it.

Diff Detail

Event Timeline

kaz7 created this revision.Nov 14 2021, 6:11 PM
Herald added a subscriber: hiraditya. · View Herald TranscriptNov 14 2021, 6:11 PM
kaz7 requested review of this revision.Nov 14 2021, 6:11 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptNov 14 2021, 6:11 PM
Harbormaster completed remote builds in B134184: Diff 387145.Nov 14 2021, 6:52 PM
simoll added a comment.Nov 15 2021, 1:55 AM

Fixed by rG7cf887b95

kaz7 abandoned this revision.Nov 15 2021, 2:40 AM

Revision Contents

PathSize
llvm/
lib/
Target/
VE/
2 lines

Diff 387145

llvm/lib/Target/VE/VEISelLowering.cpp

Show First 20 Lines • Show All 2,507 Lines • ▼ Show 20 Linesstatic bool isI32Insn(const SDNode *User, const SDNode *N) {
case ISD::CopyToReg: case ISD::CopyToReg:
// Check all use of selections, bit operations, and copies. If all of them // Check all use of selections, bit operations, and copies. If all of them
// are safe, optimize truncate to extract_subreg. // are safe, optimize truncate to extract_subreg.
for (const SDNode *U : User->uses()) { for (const SDNode *U : User->uses()) {
switch (U->getOpcode()) { switch (U->getOpcode()) {
default: default:
// If the use is an instruction which treats the source operand as i32, // If the use is an instruction which treats the source operand as i32,
// it is safe to avoid truncate here. // it is safe to avoid truncate here.
if (isI32Insn(*UI, N)) if (isI32Insn(U, N))
continue; continue;
break; break;
case ISD::ANY_EXTEND: case ISD::ANY_EXTEND:
case ISD::SIGN_EXTEND: case ISD::SIGN_EXTEND:
case ISD::ZERO_EXTEND: { case ISD::ZERO_EXTEND: {
// Special optimizations to the combination of ext and trunc. // Special optimizations to the combination of ext and trunc.
// (ext ... (select ... (trunc ...))) is safe to avoid truncate here // (ext ... (select ... (trunc ...))) is safe to avoid truncate here
// since this truncate instruction clears higher 32 bits which is filled // since this truncate instruction clears higher 32 bits which is filled
▲ Show 20 Lines • Show All 309 Lines • Show Last 20 Lines