Page MenuHomePhabricator

[clang-format] [NFC] build clang-format with -Wall
ClosedPublic

Authored by MyDeveloperDay on Sun, Nov 14, 6:35 AM.

Details

Summary

When building clang-format with -Wall on Visual Studio 20119

I see the following, prevent this the only -Wall error

..FormatTokenLexer.cpp(45) : warning C4868: compiler may not enforce left-to-right evaluation order in braced initializer list

Diff Detail

Event Timeline

MyDeveloperDay requested review of this revision.Sun, Nov 14, 6:35 AM
MyDeveloperDay created this revision.

Is okay, but I think the compiler is a bit overreacting, since there is only one call (chain).

This revision is now accepted and ready to land.Sun, Nov 14, 1:11 PM

Is okay, but I think the compiler is a bit overreacting, since there is only one call (chain).

I agree, but I think I saw that one of the buildbot was running with -Wall and I got dinged on my commit and this was our only failure (tests use include ../ which is also a failure)

This revision was automatically updated to reflect the committed changes.