This is an archive of the discontinued LLVM Phabricator instance.

[llvm-reduce] Skip replacing metadata and callee operands
ClosedPublic

Authored by aeubanks on Nov 9 2021, 6:00 PM.

Details

Summary

Metadata operands tend to require special conditions, especially on dbg
intrinsics. We also don't have a zero value for metadata.

Replacing callee operands is a little weird, since calling undef/null
doesn't make sense. It also causes tons of invalid reductions when
reducing calls to intrinsics since only arguments to intrinsics can be
of the metadata type.

Diff Detail

Event Timeline

aeubanks requested review of this revision.Nov 9 2021, 6:00 PM
aeubanks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2021, 6:00 PM
Meinersbur accepted this revision.Nov 11 2021, 12:40 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 11 2021, 12:40 PM