This is an archive of the discontinued LLVM Phabricator instance.

Differential D113506

[DebugInfo] Fix broken MachO test
ClosedPublic

Authored by ellis on Nov 9 2021, 12:11 PM.

Details

Reviewers
dblaikie
Commits
rG06736dab9bb5: [DebugInfo] Fix broken MachO test
Summary

This test was introduced in https://reviews.llvm.org/D112337 and breaks on mac.

Diff Detail

Event Timeline

ellis requested review of this revision.Nov 9 2021, 12:11 PM
ellis created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2021, 12:11 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
ellis mentioned this in D112337: [DebugInfo] Only create concrete DIEs of concrete functions.Nov 9 2021, 12:12 PM
dblaikie accepted this revision.Nov 9 2021, 12:18 PM
dblaikie added a subscriber: dblaikie.

Sure, looks like it'd be worth a shot.

This revision is now accepted and ready to land.Nov 9 2021, 12:18 PM
This revision was landed with ongoing or failed builds.Nov 9 2021, 12:46 PM
Closed by commit rG06736dab9bb5: [DebugInfo] Fix broken MachO test (authored by ellis, committed by kyulee). · Explain Why
This revision was automatically updated to reflect the committed changes.
kyulee added a commit: rG06736dab9bb5: [DebugInfo] Fix broken MachO test.
Harbormaster completed remote builds in B133330: Diff 385928.Nov 9 2021, 3:03 PM
akuegel added a reverting change: rG7b3305f4d9a2: Revert "[DebugInfo] Fix broken MachO test".Nov 10 2021, 1:50 AM

Revision Contents

PathSize
llvm/
test/
DebugInfo/
Generic/
4 lines

Diff 385944

llvm/test/DebugInfo/Generic/inlined-static-var.ll

Show All 26 Lines
; CHECK: DW_AT_name ("not_removed") ; CHECK: DW_AT_name ("not_removed")
; CHECK: DW_TAG_subprogram ; CHECK: DW_TAG_subprogram
; CHECK: DW_AT_name ("foo") ; CHECK: DW_AT_name ("foo")
; CHECK: DW_TAG_inlined_subroutine ; CHECK: DW_TAG_inlined_subroutine
; CHECK: DW_TAG_inlined_subroutine ; CHECK: DW_TAG_inlined_subroutine
; CHECK: NULL ; CHECK: NULL
; CHECK: NULL ; CHECK: NULL
$_ZZ7removedvE1A = comdat any
@_ZZ11not_removedvE1A = internal global i32 0, align 4, !dbg !0 @_ZZ11not_removedvE1A = internal global i32 0, align 4, !dbg !0
@_ZZ7removedvE1A = linkonce_odr dso_local global i32 0, comdat, align 4, !dbg !10 @_ZZ7removedvE1A = linkonce_odr dso_local global i32 0, align 4, !dbg !10
define dso_local i32 @_Z11not_removedv() !dbg !2 { define dso_local i32 @_Z11not_removedv() !dbg !2 {
%1 = load i32, i32* @_ZZ11not_removedvE1A, align 4, !dbg !24 %1 = load i32, i32* @_ZZ11not_removedvE1A, align 4, !dbg !24
%2 = add nsw i32 %1, 1, !dbg !24 %2 = add nsw i32 %1, 1, !dbg !24
store i32 %2, i32* @_ZZ11not_removedvE1A, align 4, !dbg !24 store i32 %2, i32* @_ZZ11not_removedvE1A, align 4, !dbg !24
ret i32 %1, !dbg !25 ret i32 %1, !dbg !25
} }
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines