This is an archive of the discontinued LLVM Phabricator instance.

[ADT] Add unit test for EquivalanceClasses comparator
ClosedPublic

Authored by springerm on Nov 8 2021, 10:20 PM.

Details

Summary

This unit tests tests new functionality added by D112052.

Diff Detail

Event Timeline

springerm requested review of this revision.Nov 8 2021, 10:20 PM
springerm created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2021, 10:20 PM
dblaikie added inline comments.Nov 8 2021, 10:50 PM
llvm/unittests/ADT/EquivalenceClassesTest.cpp
100–101

Could use a gunit type parameterized test for this, to avoid the duplication?

springerm updated this revision to Diff 387432.Nov 15 2021, 3:52 PM

address comments

springerm marked an inline comment as done.Nov 15 2021, 3:53 PM

sry for the slow update

dblaikie accepted this revision.Nov 16 2021, 9:09 AM

looks good, thanks!

This revision is now accepted and ready to land.Nov 16 2021, 9:09 AM
This revision was automatically updated to reflect the committed changes.