[lldb] Use is_style_posix() for path style checks

[mstorsjo]

Summary

Since a8b54834a186f5570b49b614e31b961a9cf1cbfe, there are two
distinct Windows path styles, windows_backslash (with the old
windows being an alias for it) and windows_slash.
4e4883e1f394f7c47ff3adee48039aa8374bb8d0 added helpers for
inspecting path styles.

The newly added windows_slash path style doesn't end up used in
LLDB yet anyway, as LLDB is quite decoupled from most of
llvm::sys::path and uses its own FileSpec class. To take it in
use, it could be hooked up in FileSpec::Style::GetNativeStyle
(in lldb/source/Utility/FileSpec.cpp) just like in the real_style
function in llvm/lib/Support/Path.cpp in
df0ba47c36f6bd0865e3286853b76d37e037c2d7.

It is not currently clear whether there's a real need for using
the Windows path style with forward slashes in LLDB (if there's any
other applications interacting with it, expecting that style), and
what other changes in LLDB are needed for that to work, but this
at least makes some of the checks more ready for the new style,
simplifying code a bit.

lldb/include/lldb/Utility/FileSpec.h

public:
   /// unreliable (e.g. "c:\foo.txt" is a valid relative posix path).
   static llvm::Optional<Style> GuessPathStyle(llvm::StringRef absolute_path);
 
   /// Case sensitivity of path.
   ///
   /// \return
   ///     \b true if the file path is case sensitive (POSIX), false
   ///   if case insensitive (Windows).
-  bool IsCaseSensitive() const { return m_style != Style::windows; }
+  bool IsCaseSensitive() const { return is_style_posix(m_style); }
 
   /// Dump this object to a Stream.
   ///
   /// Dump the object to the supplied stream \a s. If the object contains a
   /// valid directory name, it will be displayed followed by a directory
   /// delimiter, and the filename.
   ///
   /// \param[in] s

lldb/source/Utility/FileSpec.cpp

 #if defined(_WIN32)
   return FileSpec::Style::windows;
 #else
   return FileSpec::Style::posix;
 #endif
 }
 
 bool PathStyleIsPosix(FileSpec::Style style) {
-  return (style == FileSpec::Style::posix ||
-          (style == FileSpec::Style::native &&
-           GetNativeStyle() == FileSpec::Style::posix));
+  return llvm::sys::path::is_style_posix(style);
 }
 
 const char *GetPathSeparators(FileSpec::Style style) {
   return llvm::sys::path::get_separator(style).data();
 }
 
 char GetPreferredPathSeparator(FileSpec::Style style) {
   return GetPathSeparators(style)[0];