This is an archive of the discontinued LLVM Phabricator instance.

[tests][X86] Merge call-structfp.ll with x32-function_pointer-3.ll
AcceptedPublic

Authored by hvdijk on Nov 3 2021, 5:38 PM.

Details

Reviewers
MaskRay
Summary

As suggested by @MaskRay in D112860.

Diff Detail

Event Timeline

hvdijk created this revision.Nov 3 2021, 5:38 PM
hvdijk requested review of this revision.Nov 3 2021, 5:38 PM
MaskRay accepted this revision.Nov 3 2021, 7:13 PM
MaskRay added inline comments.
llvm/test/CodeGen/X86/x32-function_pointer-3.ll
34

add nounwind to remove .cfi_* noise. Then consider using more CHECK-NEXT

Maybe consider regenerating the CHECK patterns with update_llc_test_checks.py

This revision is now accepted and ready to land.Nov 3 2021, 7:13 PM
hvdijk added inline comments.Nov 4 2021, 11:59 AM
llvm/test/CodeGen/X86/x32-function_pointer-3.ll
34

I do not want the two tests that basically test the same thing, in slightly different cases, to test things differently: the CHECK lines here are written to match those of the existing test that was already in this file. I had an auto-generated test earlier and specifically updated it to use this file's style.