[libc++] Add XFAIL annotations for older Clangs

[ldionne]

Summary

Those were missed by https://llvm.org/D111477, which broke the CI.

[ldionne]

Since we install the nightly ToT Clang (which is clang-14) on our CI machines, it turns out that this still fails for clang-14. It will fail until the Docker images pick up a ToT Clang that contains D111477, but we don't really have control over when that happens.

That's not a great story for rolling out changes to Clang and libc++ in lockstep, we need to figure out how to do that better. Ideally we'd build Clang ToT in each job before running the tests, but that is going to be prohibitively expensive.

For now, I'm going to mark the test as UNSUPPORTED on clang-14 until the builders pick up something recent enough. Not great but it should get the CI green again.

[ldionne]

Try to address failures on Clang "ToT"

[dblaikie]

Does the matching here support regex? We could make the tests format agnostic instead? (hmm, maybe the internal stuff in lldb isn't format agnostic, though... )

[ldionne]

In D113112#3106415, @dblaikie wrote:

Does the matching here support regex? We could make the tests format agnostic instead? (hmm, maybe the internal stuff in lldb isn't format agnostic, though... )

Good suggestion.

[ldionne]

Use regexes instead.

[dblaikie]

Awesome! :) Thanks for the fix!

[dblaikie]

"This revision was not accepted when it landed; it landed in state Needs Review."

I guess since libc++'s Phab is configured to require review from a libc++ maintainer (Since I did approve it, but that didn't take it out of the "Needs Review" state, I guess?) ? Could that be fixed in some way, since it doesn't seem to match the reality of what's expected here?

libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp

 // 2. Set its value to something which will test the pretty printer in an
 //    interesting way.
 //
 // 3. Call ComparePrettyPrintToChars with that variable, and a "const char*"
 //    value to compare to the printer's output.
 //
 //    Or
 //
-//    Call ComparePrettyPrintToChars with that variable, and a "const char*"
+//    Call ComparePrettyPrintToRegex with that variable, and a "const char*"
 //    *python* regular expression to match against the printer's output.
 //    The set of special characters in a Python regular expression overlaps
 //    with a lot of things the pretty printers print--brackets, for
 //    example--so take care to escape appropriately.
 //
 // Alternatively, construct a string that gdb can parse as an expression,
 // so that printing the value of the expression will test the pretty printer
 // in an interesting way. Then, call CompareExpressionPrettyPrintToChars or
void unique_ptr_test() {
 
   std::unique_ptr<int> this_is_null;
   ComparePrettyPrintToChars(std::move(this_is_null),
       R"(std::unique_ptr is nullptr)");
 }
 
 void bitset_test() {
   std::bitset<258> i_am_empty(0);
-  ComparePrettyPrintToChars(i_am_empty, "std::bitset<258ul>");
+  ComparePrettyPrintToRegex(i_am_empty, "std::bitset<258(ul)?>");
 
   std::bitset<0> very_empty;
-  ComparePrettyPrintToChars(very_empty, "std::bitset<0ul>");
+  ComparePrettyPrintToRegex(very_empty, "std::bitset<0(ul)?>");
 
   std::bitset<15> b_000001111111100(1020);
-  ComparePrettyPrintToChars(b_000001111111100,
-      "std::bitset<15ul> = {[2] = 1, [3] = 1, [4] = 1, [5] = 1, [6] = 1, "
-      "[7] = 1, [8] = 1, [9] = 1}");
+  ComparePrettyPrintToRegex(b_000001111111100,
+      R"(std::bitset<15(ul)?> = {\[2\] = 1, \[3\] = 1, \[4\] = 1, \[5\] = 1, \[6\] = 1, )"
+      R"(\[7\] = 1, \[8\] = 1, \[9\] = 1})");
 
   std::bitset<258> b_0_129_132(0);
   b_0_129_132[0] = true;
   b_0_129_132[129] = true;
   b_0_129_132[132] = true;
-  ComparePrettyPrintToChars(b_0_129_132,
-      "std::bitset<258ul> = {[0] = 1, [129] = 1, [132] = 1}");
+  ComparePrettyPrintToRegex(b_0_129_132,
+      R"(std::bitset<258(ul)?> = {\[0\] = 1, \[129\] = 1, \[132\] = 1})");
 }
 
 void list_test() {
   std::list<int> i_am_empty{};
   ComparePrettyPrintToChars(i_am_empty, "std::list is empty");
 
   std::list<int> one_two_three {1, 2, 3};
   ComparePrettyPrintToChars(one_two_three,