This is an archive of the discontinued LLVM Phabricator instance.

[docs] Update new builder instructions to default to building each change
ClosedPublic

Authored by reames on Oct 28 2021, 6:34 PM.

Details

Summary

We generally prefer build bots which build each change as they come in as long as they can keep up. This generates much higher quality feedback to a developer. However, the code structure is such that we currently default new builders to batching.

This change updates the getting started instruction for a builder to explicitly advocate for not collapsing requests.

Diff Detail

Event Timeline

reames created this revision.Oct 28 2021, 6:34 PM
reames requested review of this revision.Oct 28 2021, 6:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2021, 6:34 PM
mehdi_amini added inline comments.Oct 28 2021, 8:32 PM
llvm/docs/HowToAddABuilder.rst
130

This is a question for Galina I guess: is there a way to configure something like maxCollapse = 3 in buildbot instead of just letting some bots email 20 people at the same time?

reames added inline comments.Oct 28 2021, 9:18 PM
llvm/docs/HowToAddABuilder.rst
130

I don't believe there is currently, but this was one of the ideas I was thinking about implementing.

gkistanova accepted this revision.Nov 1 2021, 8:35 PM

Thanks, Philip!

llvm/docs/HowToAddABuilder.rst
130

Out of the box there is no way to limit a number of collapsed build requests. It could be implemented, though.
I'm looking in to this.

This revision is now accepted and ready to land.Nov 1 2021, 8:35 PM