This is an archive of the discontinued LLVM Phabricator instance.

Differential D112738

[flang] Fix crash on "call system_clock(count_max=j)"
ClosedPublic

Authored by klausler on Oct 28 2021, 11:09 AM.

Details

Reviewers
jeanPerier
Commits
rGd0ca0595b9bd: [flang] Fix crash on "call system_clock(count_max=j)"
Summary

An erroneous entry in the intrinsics table causes semantics to
crash on a call to system_clock if the optional "count_max="
argument appears and "count=" does not.

Diff Detail

Event Timeline

klausler created this revision.Oct 28 2021, 11:09 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptOct 28 2021, 11:09 AM
klausler requested review of this revision.Oct 28 2021, 11:09 AM
Harbormaster completed remote builds in B131242: Diff 383090.Oct 28 2021, 11:15 AM
jeanPerier accepted this revision.Oct 29 2021, 12:00 AM

Thanks

This revision is now accepted and ready to land.Oct 29 2021, 12:00 AM
Closed by commit rGd0ca0595b9bd: [flang] Fix crash on "call system_clock(count_max=j)" (authored by klausler). · Explain WhyOct 29 2021, 10:51 AM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rGd0ca0595b9bd: [flang] Fix crash on "call system_clock(count_max=j)".
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2021, 10:51 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
flang/
lib/
Evaluate/
4 lines

Diff 383431

flang/lib/Evaluate/intrinsics.cpp

Show First 20 Lines • Show All 1,125 Lines • ▼ Show 20 Linesstatic const IntrinsicInterface intrinsicSubroutine[]{
{"random_seed", {"random_seed",
{{"size", DefaultInt, Rank::scalar, Optionality::optional, {{"size", DefaultInt, Rank::scalar, Optionality::optional,
common::Intent::Out}, common::Intent::Out},
{"put", DefaultInt, Rank::vector, Optionality::optional}, {"put", DefaultInt, Rank::vector, Optionality::optional},
{"get", DefaultInt, Rank::vector, Optionality::optional, {"get", DefaultInt, Rank::vector, Optionality::optional,
common::Intent::Out}}, common::Intent::Out}},
{}, Rank::elemental, IntrinsicClass::impureSubroutine}, {}, Rank::elemental, IntrinsicClass::impureSubroutine},
{"system_clock", {"system_clock",
{{"count", SameInt, Rank::scalar, Optionality::optional, {{"count", AnyInt, Rank::scalar, Optionality::optional,
common::Intent::Out}, common::Intent::Out},
{"count_rate", AnyIntOrReal, Rank::scalar, Optionality::optional, {"count_rate", AnyIntOrReal, Rank::scalar, Optionality::optional,
common::Intent::Out}, common::Intent::Out},
{"count_max", SameInt, Rank::scalar, Optionality::optional, {"count_max", AnyInt, Rank::scalar, Optionality::optional,
common::Intent::Out}}, common::Intent::Out}},
{}, Rank::elemental, IntrinsicClass::impureSubroutine}, {}, Rank::elemental, IntrinsicClass::impureSubroutine},
}; };
// TODO: Intrinsic subroutine EVENT_QUERY // TODO: Intrinsic subroutine EVENT_QUERY
// TODO: Atomic intrinsic subroutines: ATOMIC_ADD &al. // TODO: Atomic intrinsic subroutines: ATOMIC_ADD &al.
// TODO: Collective intrinsic subroutines: CO_BROADCAST &al. // TODO: Collective intrinsic subroutines: CO_BROADCAST &al.
▲ Show 20 Lines • Show All 1,446 Lines • Show Last 20 Lines