This is an archive of the discontinued LLVM Phabricator instance.

sanitizer_common: tighten on_print hook test
ClosedPublic

Authored by dvyukov on Oct 27 2021, 2:02 AM.

Details

Summary

The new tsan runtime does not support arbitrary forms
of recursing into the runtime from hooks.
Disable instrumentation of the hook and use write instead
of fwrite (calls malloc internally).
The new version still recurses (write is intercepted),
but does not fail now (the issue at hand was malloc).

Depends on D112601.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Oct 27 2021, 2:02 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2021, 2:02 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Oct 27 2021, 5:43 AM
This revision is now accepted and ready to land.Oct 27 2021, 5:43 AM
This revision was landed with ongoing or failed builds.Oct 27 2021, 6:11 AM
This revision was automatically updated to reflect the committed changes.