This is an archive of the discontinued LLVM Phabricator instance.

[NFC][Docs] Add missing Doxygen group comments for LLVM-C
ClosedPublic

Authored by supergrecko on Oct 25 2021, 11:14 AM.

Details

Summary

The LLVM-C API is relatively small, so we've previously added doxygen group tags
so it's easy to navigate LLVM-C on the web documentation. Over the years, more
LLVM-C headers have been added without the doxygen tags, effectively hiding
them from the "LLVM-C: C Interface to LLVM" doxygen page.

This patch adds doxygen group comments to the headers which did not have them
previously. The new items added to the doxygen group tree looks like this:

|-- LLVM-C
  + Linker (Linker.h)
  + Error Handling (Error.h, ErrorHandling.h)
  |-- Core
    + Comdats (Comdat.h)
    + Debug Information (DebugInfo.h)
    + New Pass Manager (Transforms/PassBuilder.h)
    + IR Reader (IRReader.h)
    + Pass Registry (moved from root)
    + Pass Manager (moved from root)
  |-- Execution Engine
    + Executon Engine LLJIT (LLJIT.h)
    + On-Request-Compilation (Orc.h)
    + ORC Execution (OrcEE.h)
  - Pass Registry
  - Pass Manager

The groups Pass Registry and PassManager have been moved into LLVMCCore as their
names hinted. (LLVMCCorePassRegistry and LLVMCCorePassManager) I believe the
original author forgot the doxygen ingroup directive which is why they were
misplaced at root.

In addition to this, the following groups have been updated:

  • Core (Support.h has been added to the group)
  • Disassembler (DisassemblerTypes.h has been added to the group)
  • Target information (TargetMachine.h has been added to the group)

Diff Detail

Event Timeline

supergrecko created this revision.Oct 25 2021, 11:14 AM
supergrecko requested review of this revision.Oct 25 2021, 11:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2021, 11:14 AM
supergrecko edited the summary of this revision. (Show Details)Oct 25 2021, 11:14 AM
lhames accepted this revision.Nov 5 2021, 10:05 PM
lhames added a subscriber: lhames.

This is a nice change -- thanks @supergrecko!

+ Executon Engine LLJIT (LLJIT.h)
+ On-Request-Compilation (Orc.h)
+ ORC Execution (OrcEE.h)

These should be changed to just "LLJIT (LLJIT.h)" and "ExecutionEngine-based ORC Utils (OrcEE.h)".

Otherwise LGTM.

This revision is now accepted and ready to land.Nov 5 2021, 10:05 PM

Rename LLJIT and OrcEE header doxygen groups

Addressing review comments:

Execution Engine LLJIT -> LLJIT
ORC Execution -> ExecutionEngine-based ORC Utils

Rename LLJIT and OrcEE header doxygen groups

Addressing review comments:

Execution Engine LLJIT -> LLJIT
ORC Execution -> ExecutionEngine-based ORC Utils