This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Change LIBCXX-WINDOWS-FIXME into XFAIL: msvc for cases that succeed in mingw configurations
ClosedPublic

Authored by mstorsjo on Oct 21 2021, 3:47 AM.

Details

Summary

Add a FIXME comment for those instances that don't yet have an
accompanying explanation comment.

Also narrow down some "XFAIL: windows-dll" into "XFAIL: windows-dll &&
msvc", for things that don't fail correspondingly in mingw configurations.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Oct 21 2021, 3:47 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 21 2021, 3:47 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested changes to this revision.Oct 21 2021, 6:56 AM
ldionne added inline comments.
libcxx/test/std/language.support/support.dynamic/alloc.errors/set.new.handler/get_new_handler.pass.cpp
11–12

I don't understand why we're not keeping LIBCXX-WINDOWS-FIXME in those cases.

This revision now requires changes to proceed.Oct 21 2021, 6:56 AM
mstorsjo requested review of this revision.Oct 21 2021, 7:15 AM
mstorsjo added inline comments.
libcxx/test/std/language.support/support.dynamic/alloc.errors/set.new.handler/get_new_handler.pass.cpp
11–12

Because LIBCXX-WINDOWS-FIXME is set in both msvc and mingw configurations, but the test succeeds in mingw configs, so the bug, whatever it is, is specific to msvc. When adding mingw CI, these tests give “unexpectedly passed” errors.

mstorsjo updated this revision to Diff 381668.Oct 22 2021, 2:56 PM

Updated after splitting out other cases. Added/clarified comments about the reason for the XFAILs in the remaining cases.

mstorsjo updated this revision to Diff 381671.Oct 22 2021, 3:12 PM

Rebase and rerun CI

ldionne accepted this revision.Oct 28 2021, 12:04 PM
This revision is now accepted and ready to land.Oct 28 2021, 12:04 PM

Thanks for adding comments, that was interesting to read. If someone wants to investigate finishing up Windows/MSVC support, they'll have an easier time.

This revision was landed with ongoing or failed builds.Oct 28 2021, 11:32 PM
This revision was automatically updated to reflect the committed changes.