This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Remove a LIBCXX-WINDOWS-FIXME, don't test an unsupported strftime() pattern
ClosedPublic

Authored by mstorsjo on Oct 22 2021, 2:56 PM.

Details

Summary

Testing the unsupported pattern can trigger the invalid parameter handler,
which depending on CRT configuration can abort the process.

Split this out from D112211, as this XFAIL actually can be fixed pretty
easily.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Oct 22 2021, 2:56 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2021, 2:56 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mstorsjo updated this revision to Diff 381670.Oct 22 2021, 3:12 PM

Rebase and rerun CI

ldionne accepted this revision.Nov 2 2021, 10:18 AM
This revision is now accepted and ready to land.Nov 2 2021, 10:18 AM
This revision was landed with ongoing or failed builds.Nov 2 2021, 12:54 PM
This revision was automatically updated to reflect the committed changes.