This is an archive of the discontinued LLVM Phabricator instance.

[mips64][mcjit] Add test for MIPS64R6 relocations, and correct some check expressions in MIPS64R2 test.
ClosedPublic

Authored by vradosavljevic on Jul 15 2015, 5:56 AM.

Details

Summary

This patch adds test for MIPS64R6 relocations, corrects check expressions for R_MIPS_26 and R_MIPS_PC16 relocations in MIPS64R2 test, and adds run for big endian in MIPS64R2 test.

Diff Detail

Repository
rL LLVM

Event Timeline

vradosavljevic retitled this revision from to [mips64][mcjit] Add test for MIPS64R6 relocations, and change some check expressions in MIPS64R2 test..
vradosavljevic updated this object.
vradosavljevic added reviewers: dsanders, petarj.
vradosavljevic set the repository for this revision to rL LLVM.
vradosavljevic added a subscriber: llvm-commits.
dsanders accepted this revision.Aug 21 2015, 6:26 AM
dsanders edited edge metadata.

LGTM

From the commit message:

changes some check expressions in MIPS64R2 test

Could you say 'correct' instead of change and summarize the correction?

lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp
684

This isn't for this patch just something I thought of while reading:

Should we warn if the 'x & ~0x7' masks any bits? I think we should. Likewise for the 'x & 0x3' cases.

This revision is now accepted and ready to land.Aug 21 2015, 6:26 AM
vradosavljevic retitled this revision from [mips64][mcjit] Add test for MIPS64R6 relocations, and change some check expressions in MIPS64R2 test. to [mips64][mcjit] Add test for MIPS64R6 relocations, and correct some check expressions in MIPS64R2 test..Aug 24 2015, 6:04 AM
vradosavljevic updated this object.
vradosavljevic edited edge metadata.
vradosavljevic added inline comments.
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp
684

Yes, we should warn.

Rebased test/ExecutionEngine/RuntimeDyld/Mips/ELF_Mips64r2N64_PIC_relocations.s to current trunk.

This revision was automatically updated to reflect the committed changes.