Page MenuHomePhabricator

vradosavljevic (Vladimir Radosavljevic)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 25 2015, 8:08 AM (234 w, 1 d)

Recent Activity

Apr 15 2016

vradosavljevic abandoned D15047: [Mips64] Fix extension of 32-bit integer types..

Abandoned in favour of http://reviews.llvm.org/D18893 .

Apr 15 2016, 6:29 AM

Nov 30 2015

vradosavljevic added a comment to D15047: [Mips64] Fix extension of 32-bit integer types..

This is the same problem Vasileios ran into when he removed some redundant sign extends. The root of the problem is that the legalized SelectionDAG isn't actually legal for MIPS64 since we don't have any 32-bit comparison operations (setlt and friends compare GPR-width values and produce a GPR-width 0 or 1). The legalizer should be promoting both the operands and result of the setcc to i64 which will result in the following DAG:

Nov 30 2015, 8:11 AM
vradosavljevic added a comment to D15047: [Mips64] Fix extension of 32-bit integer types..

Could you point me at the original problem you're trying to solve? The new node appears to be doing the same job as AssertZExt and I'm fairly certain this is headed into a bigger problem we encountered back in spring.

Nov 30 2015, 6:17 AM

Nov 27 2015

vradosavljevic added a comment to D15047: [Mips64] Fix extension of 32-bit integer types..

TruncNoExt node is used for values smaller than 32bit, where we don't need to do sign extension.

Nov 27 2015, 9:08 AM
vradosavljevic retitled D15047: [Mips64] Fix extension of 32-bit integer types. from to [Mips64] Fix extension of 32-bit integer types..
Nov 27 2015, 9:07 AM

Nov 23 2015

vradosavljevic added a comment to D14900: [mips] SelectionDAGISel subclasses now follow the optimization level..

I'm not sure what to do about the test. I've preserved what it was really testing for now but I believe the intention was to test SelectionDAG and not FastISel. Unfortunately, reverting the original change that added this test (rL237153) does not change the output of SelectionDAG.

Added the author and commit-er for their opinion.

Nov 23 2015, 7:42 AM

Aug 26 2015

vradosavljevic updated the diff for D11217: [mips64][mcjit] Add test for MIPS64R6 relocations, and correct some check expressions in MIPS64R2 test..

Rebased test/ExecutionEngine/RuntimeDyld/Mips/ELF_Mips64r2N64_PIC_relocations.s to current trunk.

Aug 26 2015, 9:45 AM
vradosavljevic updated the diff for D11293: [mips] Remove incorrect DebugLoc entries from prologue..

Updated test/DebugInfo/Mips/delay-slot.ll.

Aug 26 2015, 8:53 AM

Aug 24 2015

vradosavljevic added inline comments to D11217: [mips64][mcjit] Add test for MIPS64R6 relocations, and correct some check expressions in MIPS64R2 test..
Aug 24 2015, 6:05 AM
vradosavljevic retitled D11217: [mips64][mcjit] Add test for MIPS64R6 relocations, and correct some check expressions in MIPS64R2 test. from [mips64][mcjit] Add test for MIPS64R6 relocations, and change some check expressions in MIPS64R2 test. to [mips64][mcjit] Add test for MIPS64R6 relocations, and correct some check expressions in MIPS64R2 test..
Aug 24 2015, 6:04 AM
vradosavljevic added a comment to D11293: [mips] Remove incorrect DebugLoc entries from prologue..

Machine instructions before Prologue/Epilogue Insertion:

BB#0: derived from LLVM BB %entry
	ADJCALLSTACKDOWN 16, %SP<imp-def,dead>, %SP<imp-use>; dbg:test.c:2:3
	%AT<def> = LUi <ga:@.str>[TF=5]; dbg:test.c:2:3
	%A0<def> = ADDiu %AT<kill>, <ga:@.str>[TF=6]; dbg:test.c:2:3
	JAL <ga:@printf>, <regmask %FP %RA %D10 %D11 %D12 %D13 %D14 %D15 %F20 %F21 %F22 %F23 %F24 %F25 %F26 %F27 %F28 %F29 %F30 %F31 %S0 %S1 %S2 %S3 %S4 %S5 %S6 %S7>, %A0<imp-use,kill>, %SP<imp-def>, %V0<imp-def>, ...; dbg:test.c:2:3
	ADJCALLSTACKUP 16, 0, %SP<imp-def,dead>, %SP<imp-use>; dbg:test.c:2:3
	SW %V0<kill>, <fi#0>, 0; mem:ST4[FixedStack0] dbg:test.c:3:1
	RetRA; dbg:test.c:3:1
Aug 24 2015, 6:01 AM

Aug 12 2015

vradosavljevic updated the diff for D11186: [mips][mcjit] Calculate correct addend for R_MIPS_HI16 and R_MIPS_PCHI16 relocations..

Comments addressed.

Aug 12 2015, 6:19 AM
vradosavljevic added inline comments to D11186: [mips][mcjit] Calculate correct addend for R_MIPS_HI16 and R_MIPS_PCHI16 relocations..
Aug 12 2015, 6:19 AM

Aug 11 2015

vradosavljevic added a comment to D11186: [mips][mcjit] Calculate correct addend for R_MIPS_HI16 and R_MIPS_PCHI16 relocations..

Ping.

Aug 11 2015, 7:07 AM
vradosavljevic added a comment to D11217: [mips64][mcjit] Add test for MIPS64R6 relocations, and correct some check expressions in MIPS64R2 test..

Ping.

Aug 11 2015, 7:07 AM
vradosavljevic added a comment to D11293: [mips] Remove incorrect DebugLoc entries from prologue..

Ping.

Aug 11 2015, 7:07 AM

Jul 17 2015

vradosavljevic retitled D11293: [mips] Remove incorrect DebugLoc entries from prologue. from to [mips] Remove incorrect DebugLoc entries from prologue..
Jul 17 2015, 5:45 AM

Jul 15 2015

vradosavljevic retitled D11217: [mips64][mcjit] Add test for MIPS64R6 relocations, and correct some check expressions in MIPS64R2 test. from to [mips64][mcjit] Add test for MIPS64R6 relocations, and change some check expressions in MIPS64R2 test..
Jul 15 2015, 5:56 AM

Jul 14 2015

vradosavljevic retitled D11186: [mips][mcjit] Calculate correct addend for R_MIPS_HI16 and R_MIPS_PCHI16 relocations. from to [mips][mcjit] Calculate correct addend for R_MIPS_HI16 and R_MIPS_PCHI16 relocations..
Jul 14 2015, 6:41 AM

Jul 6 2015

vradosavljevic updated the diff for D10687: [Mips] Add support for MCJIT for MIPS32r6.

Comments addressed.

Jul 6 2015, 3:40 AM
vradosavljevic added inline comments to D10687: [Mips] Add support for MCJIT for MIPS32r6.
Jul 6 2015, 3:38 AM
vradosavljevic added a comment to D10687: [Mips] Add support for MCJIT for MIPS32r6.

Ping.

Jul 6 2015, 12:21 AM

Jun 25 2015

vradosavljevic added a comment to D10687: [Mips] Add support for MCJIT for MIPS32r6.

Also please note that in case of O32 ABI if R_MIPS_HI16 / R_MIPS_LO16 relocations
reference the _gp_disp symbol they should be calculated using special formulas:

R_MIPS_HI16: (AHL + GP – P) – (short) (AHL + GP – P)) >> 16
R_MIPS_LO16: AHL + GP – P + 4

Hmm, that could be tricky. At the moment, I'm not sure the name is available.

Jun 25 2015, 8:10 AM

Jun 24 2015

vradosavljevic added inline comments to D10687: [Mips] Add support for MCJIT for MIPS32r6.
Jun 24 2015, 7:42 AM
vradosavljevic retitled D10687: [Mips] Add support for MCJIT for MIPS32r6 from to [Mips] Add support for MCJIT for MIPS32r6.
Jun 24 2015, 5:37 AM

Jun 22 2015

vradosavljevic added inline comments to D10565: [mips64] Emit correct addend for R_MIPS_PC16, R_MIPS_PC21_S2 and R_MIPS_PC26_S2 relocations..
Jun 22 2015, 8:32 AM
vradosavljevic updated the diff for D10565: [mips64] Emit correct addend for R_MIPS_PC16, R_MIPS_PC21_S2 and R_MIPS_PC26_S2 relocations..

Comments addressed.

Jun 22 2015, 8:31 AM
vradosavljevic added a comment to D10503: Add the -mcpu= option to llvm-rtdyld..

Ping.

Jun 22 2015, 6:20 AM

Jun 19 2015

vradosavljevic retitled D10565: [mips64] Emit correct addend for R_MIPS_PC16, R_MIPS_PC21_S2 and R_MIPS_PC26_S2 relocations. from to [mips64] Emit correct addend for R_MIPS_PC16, R_MIPS_PC21_S2 and R_MIPS_PC26_S2 relocations..
Jun 19 2015, 6:57 AM

Jun 17 2015

vradosavljevic retitled D10503: Add the -mcpu= option to llvm-rtdyld. from to Add the -mcpu= option to llvm-rtdyld..
Jun 17 2015, 6:53 AM

Jun 4 2015

vradosavljevic retitled D10235: [Mips64][mcjit] Add R_MIPS_PC32 relocation. from to [Mips64][mcjit] Add R_MIPS_PC32 relocation..
Jun 4 2015, 3:40 AM

May 28 2015

vradosavljevic updated the diff for D9667: [Mips64] Add support for MCJIT for MIPS64r2 and MIPS64r6.

Comments addressed.

May 28 2015, 4:17 AM
vradosavljevic added inline comments to D9667: [Mips64] Add support for MCJIT for MIPS64r2 and MIPS64r6.
May 28 2015, 4:14 AM

May 27 2015

vradosavljevic updated the diff for D9667: [Mips64] Add support for MCJIT for MIPS64r2 and MIPS64r6.

New patch uploaded. Please take a look.

May 27 2015, 9:04 AM

May 21 2015

vradosavljevic added inline comments to D9667: [Mips64] Add support for MCJIT for MIPS64r2 and MIPS64r6.
May 21 2015, 8:47 AM

May 20 2015

vradosavljevic added inline comments to D9667: [Mips64] Add support for MCJIT for MIPS64r2 and MIPS64r6.
May 20 2015, 7:18 AM

May 15 2015

vradosavljevic updated the diff for D9667: [Mips64] Add support for MCJIT for MIPS64r2 and MIPS64r6.

Comments addressed. Added llvm-rtdyld checker test, marked MCJIT and OrcMCJIT PIC tests as XFAIL only for mips32 architecture, and added an error report when using N32/O32 ABI's with Mips64 triple.

May 15 2015, 9:55 AM
vradosavljevic added inline comments to D9667: [Mips64] Add support for MCJIT for MIPS64r2 and MIPS64r6.
May 15 2015, 9:53 AM

May 12 2015

vradosavljevic added a comment to D8895: [Mips] Return false for isFPCloseToIncomingSP().

Is this ok to commit?

May 12 2015, 6:50 AM

May 11 2015

vradosavljevic updated subscribers of D9667: [Mips64] Add support for MCJIT for MIPS64r2 and MIPS64r6.
May 11 2015, 8:47 AM
vradosavljevic retitled D9667: [Mips64] Add support for MCJIT for MIPS64r2 and MIPS64r6 from to [Mips64] Add support for MCJIT for MIPS64r2 and MIPS64r6.
May 11 2015, 8:46 AM

Apr 28 2015

vradosavljevic added a comment to D8895: [Mips] Return false for isFPCloseToIncomingSP().

Ping.

Apr 28 2015, 9:59 AM

Apr 22 2015

vradosavljevic added inline comments to D8895: [Mips] Return false for isFPCloseToIncomingSP().
Apr 22 2015, 7:51 AM
vradosavljevic updated the diff for D8895: [Mips] Return false for isFPCloseToIncomingSP().

Comment addressed.

Apr 22 2015, 7:47 AM

Apr 17 2015

vradosavljevic added a comment to D8895: [Mips] Return false for isFPCloseToIncomingSP().

Ping.

Apr 17 2015, 6:58 AM

Apr 8 2015

vradosavljevic retitled D8895: [Mips] Return false for isFPCloseToIncomingSP() from to [Mips] Return false for isFPCloseToIncomingSP().
Apr 8 2015, 7:03 AM
vradosavljevic updated the diff for D8170: [Mips] Generate warning for invalid combination of '-mnan' and '-march' options..

Comments addressed.

Apr 8 2015, 2:07 AM
vradosavljevic added inline comments to D8170: [Mips] Generate warning for invalid combination of '-mnan' and '-march' options..
Apr 8 2015, 2:07 AM

Apr 2 2015

vradosavljevic added inline comments to D8170: [Mips] Generate warning for invalid combination of '-mnan' and '-march' options..
Apr 2 2015, 4:42 AM

Mar 30 2015

vradosavljevic updated the diff for D8170: [Mips] Generate warning for invalid combination of '-mnan' and '-march' options..

New patch uploaded.

Mar 30 2015, 7:48 AM
vradosavljevic added inline comments to D8170: [Mips] Generate warning for invalid combination of '-mnan' and '-march' options..
Mar 30 2015, 7:38 AM

Mar 16 2015

vradosavljevic updated the diff for D8170: [Mips] Generate warning for invalid combination of '-mnan' and '-march' options..
Mar 16 2015, 9:38 AM
vradosavljevic updated the diff for D8170: [Mips] Generate warning for invalid combination of '-mnan' and '-march' options..

New patch uploaded. The part of Preprocessor/init.c test is removed, because mips32r2 architecture is on the legacy-only list.

Mar 16 2015, 9:12 AM
vradosavljevic added inline comments to D8170: [Mips] Generate warning for invalid combination of '-mnan' and '-march' options..
Mar 16 2015, 9:08 AM

Mar 9 2015

vradosavljevic retitled D8170: [Mips] Generate warning for invalid combination of '-mnan' and '-march' options. from to [Mips] Generate warning for invalid combination of '-mnan' and '-march' options..
Mar 9 2015, 8:24 AM

Feb 26 2015

vradosavljevic updated the diff for D7882: Add support for generating MIPS legacy NaN.

Comments addressed.

Feb 26 2015, 9:18 AM
vradosavljevic added inline comments to D7882: Add support for generating MIPS legacy NaN.
Feb 26 2015, 9:16 AM
vradosavljevic updated the diff for D7882: Add support for generating MIPS legacy NaN.

New patch uploaded.

Feb 26 2015, 8:22 AM
vradosavljevic added inline comments to D7882: Add support for generating MIPS legacy NaN.
Feb 26 2015, 8:22 AM
vradosavljevic added inline comments to D7882: Add support for generating MIPS legacy NaN.
Feb 26 2015, 5:28 AM

Feb 25 2015

vradosavljevic retitled D7882: Add support for generating MIPS legacy NaN from to Add support for generating MIPS legacy NaN.
Feb 25 2015, 8:18 AM