This is an archive of the discontinued LLVM Phabricator instance.

Differential D112031

[libc++] Move LIBCXX-DEBUG-FIXME to params.py
ClosedPublic

Authored by ldionne on Oct 18 2021, 1:20 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGcbe3b6b21f6d: [libc++] Move LIBCXX-DEBUG-FIXME to params.py
Summary

This temporary FIXME really belongs to the testing config, not to the
specific CMake cache that enables that configuration.

Diff Detail

Event Timeline

ldionne created this revision.Oct 18 2021, 1:20 PM
Herald added subscribers: arichardson, mgorny. · View Herald TranscriptOct 18 2021, 1:20 PM
ldionne requested review of this revision.Oct 18 2021, 1:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2021, 1:20 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B129422: Diff 380508.Oct 18 2021, 2:08 PM
ldionne updated this revision to Diff 380708.Oct 19 2021, 9:12 AM

Fix obvious issue

Harbormaster completed remote builds in B129564: Diff 380708.Oct 19 2021, 11:18 AM
ldionne accepted this revision.Oct 20 2021, 6:22 AM
This revision is now accepted and ready to land.Oct 20 2021, 6:22 AM
Closed by commit rGcbe3b6b21f6d: [libc++] Move LIBCXX-DEBUG-FIXME to params.py (authored by ldionne). · Explain WhyOct 20 2021, 6:23 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rGcbe3b6b21f6d: [libc++] Move LIBCXX-DEBUG-FIXME to params.py.

Revision Contents

PathSize
libcxx/
cmake/
caches/
2 lines
utils/
libcxx/
test/
7 lines

Diff 380932

libcxx/cmake/caches/Generic-debug-iterators.cmake

set(LIBCXX_TEST_PARAMS "debug_level=1" "additional_features=LIBCXX-DEBUG-FIXME" CACHE STRING "") set(LIBCXX_TEST_PARAMS "debug_level=1" CACHE STRING "")
set(LIBCXXABI_TEST_PARAMS "${LIBCXX_TEST_PARAMS}" CACHE STRING "") set(LIBCXXABI_TEST_PARAMS "${LIBCXX_TEST_PARAMS}" CACHE STRING "")

libcxx/utils/libcxx/test/params.py

Show First 20 Lines • Show All 117 Lines • ▼ Show 20 LinesDEFAULT_PARAMETERS = [
Parameter(name='enable_warnings', choices=[True, False], type=bool, default=True, Parameter(name='enable_warnings', choices=[True, False], type=bool, default=True,
help="Whether to enable warnings when compiling the test suite.", help="Whether to enable warnings when compiling the test suite.",
actions=lambda warnings: [] if not warnings else [ actions=lambda warnings: [] if not warnings else [
AddOptionalWarningFlag(w) for w in _warningFlags AddOptionalWarningFlag(w) for w in _warningFlags
]), ]),
Parameter(name='debug_level', choices=['', '0', '1'], type=str, default='', Parameter(name='debug_level', choices=['', '0', '1'], type=str, default='',
help="The debugging level to enable in the test suite.", help="The debugging level to enable in the test suite.",
actions=lambda debugLevel: [] if debugLevel == '' else [ actions=lambda debugLevel: [] if debugLevel == '' else filter(None, [
AddFeature('debug_level={}'.format(debugLevel)), AddFeature('debug_level={}'.format(debugLevel)),
AddCompileFlag('-D_LIBCPP_DEBUG={}'.format(debugLevel)) AddCompileFlag('-D_LIBCPP_DEBUG={}'.format(debugLevel)),
]), AddFeature('LIBCXX-DEBUG-FIXME') if debugLevel == '1' else None
])),
Parameter(name='use_sanitizer', choices=['', 'Address', 'Undefined', 'Memory', 'MemoryWithOrigins', 'Thread', 'DataFlow', 'Leaks'], type=str, default='', Parameter(name='use_sanitizer', choices=['', 'Address', 'Undefined', 'Memory', 'MemoryWithOrigins', 'Thread', 'DataFlow', 'Leaks'], type=str, default='',
help="An optional sanitizer to enable when building and running the test suite.", help="An optional sanitizer to enable when building and running the test suite.",
actions=lambda sanitizer: filter(None, [ actions=lambda sanitizer: filter(None, [
AddFlag('-g -fno-omit-frame-pointer') if sanitizer else None, AddFlag('-g -fno-omit-frame-pointer') if sanitizer else None,
AddFlag('-fsanitize=undefined -fno-sanitize=float-divide-by-zero -fno-sanitize-recover=all') if sanitizer == 'Undefined' else None, AddFlag('-fsanitize=undefined -fno-sanitize=float-divide-by-zero -fno-sanitize-recover=all') if sanitizer == 'Undefined' else None,
AddFeature('ubsan') if sanitizer == 'Undefined' else None, AddFeature('ubsan') if sanitizer == 'Undefined' else None,
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines