This is an archive of the discontinued LLVM Phabricator instance.

Differential D111974

Fix bazel build.
ClosedPublic

Authored by akuegel on Oct 18 2021, 12:39 AM.

Download Raw Diff

Details

Reviewers

Commits

rG605efd5dd5bf: Fix bazel build.

Summary

This is a temporary fix, better would be to avoid including
llvm/Option/ArgList.h from a Support source file.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

akuegel requested review of this revision.Oct 18 2021, 12:39 AM

akuegel created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2021, 12:39 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B129271: Diff 380286.Oct 18 2021, 12:43 AM

Second attempt.

Harbormaster completed remote builds in B129272: Diff 380289.Oct 18 2021, 12:50 AM

Third attempt.

Harbormaster completed remote builds in B129274: Diff 380292.Oct 18 2021, 1:01 AM

akuegel added a reviewer: pifon2a.Oct 18 2021, 1:05 AM

pifon2a accepted this revision.Oct 18 2021, 1:09 AM

This revision is now accepted and ready to land.Oct 18 2021, 1:09 AM

Closed by commit rG605efd5dd5bf: Fix bazel build. (authored by akuegel). · Explain WhyOct 18 2021, 1:23 AM

This revision was automatically updated to reflect the committed changes.

akuegel added a commit: rG605efd5dd5bf: Fix bazel build..

Revision Contents

Path

Size

utils/

bazel/

llvm-project-overlay/

llvm/

2 lines

Diff 380286

utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

	Show First 20 Lines • Show All 168 Lines • ▼ Show 20 Lines

	cc_library(			cc_library(
	name = "Support",			name = "Support",
	srcs = glob([			srcs = glob([
	"lib/Support/*.c",			"lib/Support/*.c",
	"lib/Support/*.cpp",			"lib/Support/*.cpp",
	"lib/Support/*.h",			"lib/Support/*.h",
	"lib/Support/*.inc",			"lib/Support/*.inc",
				# To avoid a dependency cycle.
				"include/llvm/Option/ArgList.h",
	]) + select({			]) + select({
	"@bazel_tools//src/conditions:windows": glob([			"@bazel_tools//src/conditions:windows": glob([
	"lib/Support/Windows/*.h",			"lib/Support/Windows/*.h",
	"lib/Support/Windows/*.inc",			"lib/Support/Windows/*.inc",
	]),			]),
	"//conditions:default": glob([			"//conditions:default": glob([
	"lib/Support/Unix/*.h",			"lib/Support/Unix/*.h",
	"lib/Support/Unix/*.inc",			"lib/Support/Unix/*.inc",
	▲ Show 20 Lines • Show All 4,073 Lines • Show Last 20 Lines