This is an archive of the discontinued LLVM Phabricator instance.

[clang] Disable -clear-ast-before-backend with -print-stats
ClosedPublic

Authored by aeubanks on Oct 17 2021, 11:23 PM.

Details

Summary

We still need access to various things in the ASTContext when printing stats.

Diff Detail

Event Timeline

aeubanks requested review of this revision.Oct 17 2021, 11:23 PM
aeubanks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2021, 11:23 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
dblaikie accepted this revision.Oct 17 2021, 11:34 PM

Could you check some of the stats output is valid/expected, not just corrupt/garbage? "just doesn't crash" isn't a great criteria for a test.

This revision is now accepted and ready to land.Oct 17 2021, 11:34 PM

Could you check some of the stats output is valid/expected, not just corrupt/garbage? "just doesn't crash" isn't a great criteria for a test.

forgot to upload the diff, but I did so in the committed change

Could you check some of the stats output is valid/expected, not just corrupt/garbage? "just doesn't crash" isn't a great criteria for a test.

forgot to upload the diff, but I did so in the committed change

oh wait phab updated with the committed change, I didn't know that happened