Page MenuHomePhabricator

[TableGen] Fix codgen of InstrMapping with multiple columns and values
ClosedPublic

Authored by jyyou.tw on Oct 17 2021, 7:01 AM.

Details

Summary

This patch fixes invalid syntax of generated code for InstrMapping
that has multiple columns and values.

Diff Detail

Event Timeline

jyyou.tw requested review of this revision.Oct 17 2021, 7:01 AM
jyyou.tw created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2021, 7:01 AM
craig.topper accepted this revision.Oct 24 2021, 6:35 PM

LGTM. I guess no in tree targets are affected by this?

This revision is now accepted and ready to land.Oct 24 2021, 6:35 PM

LGTM. I guess no in tree targets are affected by this?

Yes, no target is affected.
By the way, I have no commit access. Could you submit it?

LGTM. I guess no in tree targets are affected by this?

Yes, no target is affected.
By the way, I have no commit access. Could you submit it?

Sure. How do you want your name and email to appear in the git log?

LGTM. I guess no in tree targets are affected by this?

Yes, no target is affected.
By the way, I have no commit access. Could you submit it?

Sure. How do you want your name and email to appear in the git log?

Jyun-Yan You <jyyou.tw@gmail.com>

Thanks