This is an archive of the discontinued LLVM Phabricator instance.

Differential D111840

[hwasan] Add default "/" prefix.
ClosedPublic

Authored by eugenis on Oct 14 2021, 2:29 PM.

Details

Reviewers
vitalybuka
hctim
Commits
rG039096ee7137: [hwasan] Add default "/" prefix.
Summary

Add a default "/" prefix to the symbol search path in the
symbolization script. Without this, the binary itself is not considered
a valid source of symbol info.

Diff Detail

Event Timeline

eugenis requested review of this revision.Oct 14 2021, 2:29 PM
eugenis created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 14 2021, 2:29 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B128955: Diff 379842.Oct 14 2021, 2:34 PM
hctim added inline comments.Oct 14 2021, 2:35 PM
compiler-rt/lib/hwasan/scripts/hwasan_symbolize
199–203

this branch is now dead.

eugenis updated this revision to Diff 379855.Oct 14 2021, 2:50 PM

address comment

compiler-rt/lib/hwasan/scripts/hwasan_symbolize
199–203

That's a very good point.

hctim accepted this revision.Oct 14 2021, 2:51 PM
This revision is now accepted and ready to land.Oct 14 2021, 2:51 PM
Harbormaster completed remote builds in B128964: Diff 379855.Oct 14 2021, 2:57 PM
This revision was landed with ongoing or failed builds.Oct 14 2021, 3:03 PM
Closed by commit rG039096ee7137: [hwasan] Add default "/" prefix. (authored by eugenis). · Explain Why
This revision was automatically updated to reflect the committed changes.
eugenis added a commit: rG039096ee7137: [hwasan] Add default "/" prefix..

Revision Contents

PathSize
compiler-rt/
lib/
hwasan/
scripts/
1 line

Diff 379855

compiler-rt/lib/hwasan/scripts/hwasan_symbolize

Show First 20 Lines • Show All 190 Lines • ▼ Show 20 Lines
parser.add_argument('--symbols', action='append') parser.add_argument('--symbols', action='append')
parser.add_argument('--source', action='append') parser.add_argument('--source', action='append')
parser.add_argument('--symbolizer') parser.add_argument('--symbolizer')
parser.add_argument('args', nargs=argparse.REMAINDER) parser.add_argument('args', nargs=argparse.REMAINDER)
args = parser.parse_args() args = parser.parse_args()
# Unstripped binaries location. # Unstripped binaries location.
binary_prefixes = args.symbols or [] binary_prefixes = args.symbols or []
if not binary_prefixes: if not binary_prefixes:
if 'ANDROID_PRODUCT_OUT' in os.environ: if 'ANDROID_PRODUCT_OUT' in os.environ:
product_out = os.path.join(os.environ['ANDROID_PRODUCT_OUT'], 'symbols') product_out = os.path.join(os.environ['ANDROID_PRODUCT_OUT'], 'symbols')
binary_prefixes.append(product_out) binary_prefixes.append(product_out)
binary_prefixes.append('/')
hctimUnsubmitted
Not Done
ReplyInline Actions

this branch is now dead.

hctim: this branch is now dead.
eugenisAuthorUnsubmitted
Done
ReplyInline Actions

That's a very good point.

eugenis: That's a very good point.
for p in binary_prefixes: for p in binary_prefixes:
if not os.path.isdir(p): if not os.path.isdir(p):
print >>sys.stderr, "Symbols path does not exist or is not a directory:", p print >>sys.stderr, "Symbols path does not exist or is not a directory:", p
sys.exit(1) sys.exit(1)
# Source location. # Source location.
paths_to_cut = args.source or [] paths_to_cut = args.source or []
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines