[DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

[xgupta]

clang/docs/HowToSetupToolingForLLVM.rst

157

git -> https

clang/docs/LibASTMatchersTutorial.rst

33

https would be the right protocol as per the consistency with other places of docs.

34

why removed cd ninja & git checkout release?

[SamuelMarks]

clang/docs/LibASTMatchersTutorial.rst

34

@xgupta To match how ninja is installed everywhere else in LLVM guides. Also ninja's release branch is almost a year old, whereas its master is 5 days old.

[SamuelMarks]

Also updates appveyor to latest release version of ninja

[xgupta]

clang/docs/LibASTMatchersTutorial.rst

34

fine, but we need to cd into ninja directory to run configure step, right?

[xgupta]

Please update the patch full context, see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface if using the web interface.
(git diff HEAD~1 -U999999 > mypatch.patch)

[SamuelMarks]

pushd/popd to the various build dirs

clang/docs/LibASTMatchersTutorial.rst

34

Good point, I'll fix all of them with pushd and popd

[SamuelMarks]

push/popd for build dirs

[xgupta]

The patch is not applying cleanly so can't be committed. please follow the above phabricator docs I suggested before to upload it.

add @Mordante for libcxx change.

[SamuelMarks]

In D111490#3053564, @xgupta wrote:

The patch is not applying cleanly so can't be committed. please follow the above phabricator docs I suggested before to upload it.

Oh there was an error in the web interface which told me to retry. Will check the docs on how to delete|supersede diffs

clang/docs/HowToSetupToolingForLLVM.rst

 
 .. code-block:: console
 
-  $ git clone git://github.com/ninja-build/ninja.git
+  $ git clone https://github.com/ninja-build/ninja
   $ cd ninja/
   $ ./configure.py --bootstrap
 

clang/docs/LibASTMatchersTutorial.rst

 .. code-block:: console
 
       cd ~/clang-llvm
-      git clone git://github.com/ninja-build/ninja.git
+      git clone https://github.com/ninja-build/ninja
+      pushd ninja
       ./configure.py --bootstrap
       sudo cp ninja /usr/local/bin/
+      popd
 
-      cd ~/clang-llvm
       git clone git://cmake.org/stage/cmake.git
       cd cmake
       git checkout next
       ./bootstrap
       make
       sudo make install
+      popd
 
 Okay. Now we'll build Clang!
 
 .. code-block:: console
 
-      cd ~/clang-llvm
-      mkdir build && cd build
+      mkdir build && pushd build
       cmake -G Ninja ../llvm -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" -DLLVM_BUILD_TESTS=ON  # Enable tests; default is off.
       ninja
       ninja check       # Test LLVM only.
       ninja clang-test  # Test Clang only.
       ninja install
+      popd
 
 And we're live.
 

libcxx/appveyor-reqs-install.cmd

 :: Install Ninja
 ::###########################################################################
 if NOT EXIST ninja (
-  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.6.0/ninja-win.zip -FileName ninja.zip
+  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-win.zip -FileName ninja.zip
   7z x ninja.zip -oC:\projects\deps\ninja > nul
   rm ninja.zip
 )