This is an archive of the discontinued LLVM Phabricator instance.

Differential D111486

[Support][mips] Remove unnecessary includes from Memory.inc
ClosedPublic

Authored by visa on Oct 9 2021, 4:11 AM.

Download Raw Diff

Details

Reviewers

Commits

rGa5de04d26171: [Support][mips] Remove unnecessary includes from Memory.inc

Summary

The mips-specific includes have been unnecessary ever since
the __clear_cache() builtin replaced cacheflush().

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

visa created this revision.Oct 9 2021, 4:11 AM

Herald added subscribers: dexonsmith, atanasyan, hiraditya and 3 others. · View Herald TranscriptOct 9 2021, 4:11 AM

visa requested review of this revision.Oct 9 2021, 4:11 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2021, 4:11 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B127922: Diff 378432.Oct 9 2021, 6:39 AM

LGTM. Do you have commit access?

This revision is now accepted and ready to land.Oct 12 2021, 12:41 AM

I don't have commit access. Could you commit this for me?

Closed by commit rGa5de04d26171: [Support][mips] Remove unnecessary includes from Memory.inc (authored by visa, committed by atanasyan). · Explain WhyOct 12 2021, 9:50 PM

This revision was automatically updated to reflect the committed changes.

atanasyan added a commit: rGa5de04d26171: [Support][mips] Remove unnecessary includes from Memory.inc.

Thanks for the patch.

Revision Contents

Path

Size

llvm/

lib/

Support/

Unix/

8 lines

Diff 379275

llvm/lib/Support/Unix/Memory.inc

	Show All 23 Lines
	#ifdef __APPLE__			#ifdef __APPLE__
	#include <mach/mach.h>			#include <mach/mach.h>
	#endif			#endif

	#ifdef __Fuchsia__			#ifdef __Fuchsia__
	#include <zircon/syscalls.h>			#include <zircon/syscalls.h>
	#endif			#endif

	#if defined(__mips__)
	# if defined(__OpenBSD__)
	# include <mips64/sysarch.h>
	# elif !defined(__FreeBSD__)
	# include <sys/cachectl.h>
	# endif
	#endif

	#if defined(__APPLE__)			#if defined(__APPLE__)
	extern "C" void sys_icache_invalidate(const void *Addr, size_t len);			extern "C" void sys_icache_invalidate(const void *Addr, size_t len);
	#else			#else
	extern "C" void __clear_cache(void , void);			extern "C" void __clear_cache(void , void);
	#endif			#endif

	static int getPosixProtectionFlags(unsigned Flags) {			static int getPosixProtectionFlags(unsigned Flags) {
	switch (Flags & llvm::sys::Memory::MF_RWE_MASK) {			switch (Flags & llvm::sys::Memory::MF_RWE_MASK) {
	▲ Show 20 Lines • Show All 218 Lines • Show Last 20 Lines