This is an archive of the discontinued LLVM Phabricator instance.

Differential D111449

[flang] Fix capitalization of "ishft"
ClosedPublic

Authored by PeteSteinfeld on Oct 8 2021, 11:32 AM.

Details

Reviewers
klausler
Commits
rG0620b12209cf: [flang] Fix capitalization of "ishft"
Summary

We weren't recognizing the ISHFT intrinsic because the code had
incorrectly capitalized it.

Diff Detail

Event Timeline

PeteSteinfeld created this revision.Oct 8 2021, 11:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2021, 11:32 AM
PeteSteinfeld requested review of this revision.Oct 8 2021, 11:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2021, 11:32 AM
Herald added subscribers: llvm-commits, jdoerfert. · View Herald Transcript
PeteSteinfeld added a reviewer: klausler.Oct 8 2021, 11:33 AM
Harbormaster completed remote builds in B127839: Diff 378318.Oct 8 2021, 11:43 AM
klausler accepted this revision.Oct 8 2021, 12:57 PM
This revision is now accepted and ready to land.Oct 8 2021, 12:57 PM
Closed by commit rG0620b12209cf: [flang] Fix capitalization of "ishft" (authored by PeteSteinfeld). · Explain WhyOct 8 2021, 1:44 PM
This revision was automatically updated to reflect the committed changes.
PeteSteinfeld added a commit: rG0620b12209cf: [flang] Fix capitalization of "ishft".

Revision Contents

PathSize
flang/
lib/
Evaluate/
2 lines

Diff 378348

flang/lib/Evaluate/fold-integer.cpp

Show First 20 Lines • Show All 609 Lines • ▼ Show 20 LinesExpr<Type<TypeCategory::Integer, KIND>> FoldIntrinsicFunction(
} else if (name == "iparity") { } else if (name == "iparity") {
return FoldBitReduction( return FoldBitReduction(
context, std::move(funcRef), &Scalar<T>::IEOR, Scalar<T>{}); context, std::move(funcRef), &Scalar<T>::IEOR, Scalar<T>{});
} else if (name == "ishft" || name == "shifta" || name == "shiftr" || } else if (name == "ishft" || name == "shifta" || name == "shiftr" ||
name == "shiftl") { name == "shiftl") {
// Second argument can be of any kind. However, it must be smaller or // Second argument can be of any kind. However, it must be smaller or
// equal than BIT_SIZE. It can be converted to Int4 to simplify. // equal than BIT_SIZE. It can be converted to Int4 to simplify.
auto fptr{&Scalar<T>::ISHFT}; auto fptr{&Scalar<T>::ISHFT};
if (name == "ISHFT") { // done in fptr definition if (name == "ishft") { // done in fptr definition
} else if (name == "shifta") { } else if (name == "shifta") {
fptr = &Scalar<T>::SHIFTA; fptr = &Scalar<T>::SHIFTA;
} else if (name == "shiftr") { } else if (name == "shiftr") {
fptr = &Scalar<T>::SHIFTR; fptr = &Scalar<T>::SHIFTR;
} else if (name == "shiftl") { } else if (name == "shiftl") {
fptr = &Scalar<T>::SHIFTL; fptr = &Scalar<T>::SHIFTL;
} else { } else {
common::die("missing case to fold intrinsic function %s", name.c_str()); common::die("missing case to fold intrinsic function %s", name.c_str());
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines