Page MenuHomePhabricator

[driver] Explicitly specify `-fbuild-session-timestamp` in seconds.

Authored by vsapsai on Oct 5 2021, 8:01 PM.



Representation of the file's last modification time depends on the file
system and isn't guaranteed to be in seconds. Cast to seconds explicitly
and tighten the test case to check the magnitude of the calculated
value, so we can catch passing milliseconds or nanoseconds.


Diff Detail

Event Timeline

vsapsai created this revision.Oct 5 2021, 8:01 PM
vsapsai requested review of this revision.Oct 5 2021, 8:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2021, 8:01 PM

Ping. Failed tests seem to be unrelated (don't know how this change would cause " cannot open shared object file: No such file or directory"). If you think it would be better, can rebase and trigger new builds.

benlangmuir accepted this revision.Oct 18 2021, 10:04 AM
This revision is now accepted and ready to land.Oct 18 2021, 10:04 AM
This revision was landed with ongoing or failed builds.Oct 19 2021, 1:31 PM
This revision was automatically updated to reflect the committed changes.

Thanks for the review!