Expose setPersonalityFn to Go

[axw]

Summary

Add Value.SetPersonality to the Go bindings. The Go
bindings' Builder.CreateLandingPad has been updated,
removing the obsolete personality argument.

Background

The personality attribute was removed from LandingPadInst
in r239940, and llvm::Function::setPersonalityFn introduced.

There was no corresponding change to either the C API or
Go bindings. The Go bindings were broken until r239940, but
that change was just to ignore the personality argument.
This broke llgo.

[pcc]

D10946 makes a similar change to the C API. It's ready to land, so you could commit it and update this change to use it instead.

[deadalnix]

You need the getter as well.

[axw]

In D11116#203509, @deadalnix wrote:

You need the getter as well.

Not foot what I'm doing, but yes, it should probably have both. I've accepted your rev, land away and I'll update the Go bindings here. Thanks.

[axw]

Update to base on top of D10946

[pcc]

LGTM

bindings/go/llvm/ir.go

 func (v Value) RemoveFunctionAttr(a Attribute) { C.LLVMRemoveFunctionAttr2(v.C, C.uint64_t(a)) }
 func (v Value) AddTargetDependentFunctionAttr(attr, value string) {
   cattr := C.CString(attr)
   defer C.free(unsafe.Pointer(cattr))
   cvalue := C.CString(value)
   defer C.free(unsafe.Pointer(cvalue))
   C.LLVMAddTargetDependentFunctionAttr(v.C, cattr, cvalue)
 }
+func (v Value) SetPersonality(p Value) {
+  C.LLVMSetPersonalityFn(v.C, p.C)
+}
 
 // Operations on parameters
 func (v Value) ParamsCount() int { return int(C.LLVMCountParams(v.C)) }
 func (v Value) Params() []Value {
   out := make([]Value, v.ParamsCount())
   if len(out) > 0 {
     C.LLVMGetParams(v.C, llvmValueRefPtr(&out[0]))
   }
func (b Builder) InsertWithName(instr Value, name string) {
   C.LLVMInsertIntoBuilderWithName(b.C, instr.C, cname)
 }
 func (b Builder) Dispose() { C.LLVMDisposeBuilder(b.C) }
 
 // Metadata
 func (b Builder) SetCurrentDebugLocation(line, col uint, scope, inlinedAt Metadata) {
   C.LLVMSetCurrentDebugLocation2(b.C, C.unsigned(line), C.unsigned(col), scope.C, inlinedAt.C)
 }
-func (b Builder) SetInstDebugLocation(v Value)    { C.LLVMSetInstDebugLocation(b.C, v.C) }
+func (b Builder) SetInstDebugLocation(v Value) { C.LLVMSetInstDebugLocation(b.C, v.C) }
 func (b Builder) InsertDeclare(module Module, storage Value, md Value) Value {
   f := module.NamedFunction("llvm.dbg.declare")
   if f.IsNil() {
     ftyp := FunctionType(VoidType(), []Type{storage.Type(), md.Type()}, false)
     f = AddFunction(module, "llvm.dbg.declare", ftyp)
   }
   return b.CreateCall(f, []Value{storage, md}, "")
 }

 }
 func (b Builder) CreatePtrDiff(lhs, rhs Value, name string) (v Value) {
   cname := C.CString(name)
   defer C.free(unsafe.Pointer(cname))
   v.C = C.LLVMBuildPtrDiff(b.C, lhs.C, rhs.C, cname)
   return
 }
 
-func (b Builder) CreateLandingPad(t Type, personality Value, nclauses int, name string) (l Value) {
+func (b Builder) CreateLandingPad(t Type, nclauses int, name string) (l Value) {
   cname := C.CString(name)
   defer C.free(unsafe.Pointer(cname))
   l.C = C.LLVMBuildLandingPad(b.C, t.C, C.unsigned(nclauses), cname)
   return l
 }
 
 func (l Value) AddClause(v Value) {
   C.LLVMAddClause(l.C, v.C)