This is an archive of the discontinued LLVM Phabricator instance.

tsan: don't instrument runtime callbacks in tests
ClosedPublic

Authored by dvyukov on Oct 5 2021, 7:58 AM.

Details

Summary

These runtime callbacks are supposed to be non-instrumented,
we can't handle runtime recursion well, nor can we afford
explicit recursion checks in the hot functions (memory access,
function entry/exit).
It used to work (not crash), but it won't work with the new runtime.
Mark all runtime callbacks as non-instrumented.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Oct 5 2021, 7:58 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2021, 7:58 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka accepted this revision.Oct 5 2021, 3:47 PM
This revision is now accepted and ready to land.Oct 5 2021, 3:47 PM
This revision was automatically updated to reflect the committed changes.