This is an archive of the discontinued LLVM Phabricator instance.

Differential D111071

[ELF][test] Enhance relative dynamic relocation tests
ClosedPublic

Authored by andrewng on Oct 4 2021, 9:30 AM.

Details

Reviewers
MaskRay
pcc
Commits
rG3334b9d70bc8: [ELF][test] Enhance relative dynamic relocation tests
Summary

Add checking of the value of the relocation with an addend. Also check
all relocation offsets.

Diff Detail

Event Timeline

andrewng created this revision.Oct 4 2021, 9:30 AM
Herald added a subscriber: emaste. · View Herald TranscriptOct 4 2021, 9:30 AM
andrewng requested review of this revision.Oct 4 2021, 9:30 AM
MaskRay accepted this revision.Oct 4 2021, 5:41 PM

LG

This revision is now accepted and ready to land.Oct 4 2021, 5:41 PM
Closed by commit rG3334b9d70bc8: [ELF][test] Enhance relative dynamic relocation tests (authored by andrewng). · Explain WhyOct 5 2021, 3:35 AM
This revision was automatically updated to reflect the committed changes.
andrewng added a commit: rG3334b9d70bc8: [ELF][test] Enhance relative dynamic relocation tests.
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2021, 3:35 AM

Revision Contents

PathSize
lld/
test/
ELF/
7 lines
13 lines

Diff 377144

lld/test/ELF/relative-dynamic-reloc-pie.s

# REQUIRES: x86 # REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
# RUN: ld.lld -pie %t.o -o %t.pie # RUN: ld.lld -pie %t.o -o %t.pie
# RUN: llvm-readobj -r --dyn-syms %t.pie | FileCheck %s # RUN: llvm-readobj -r --dyn-syms %t.pie | FileCheck %s
## Test that we create R_X86_64_RELATIVE relocations with -pie. ## Test that we create R_X86_64_RELATIVE relocations with -pie.
# CHECK: Relocations [ # CHECK: Relocations [
# CHECK-NEXT: Section ({{.*}}) .rela.dyn { # CHECK-NEXT: Section ({{.*}}) .rela.dyn {
# CHECK-NEXT: 0x3368 R_X86_64_RELATIVE - 0x3368 # CHECK-NEXT: 0x[[FOO_ADDR:.*]] R_X86_64_RELATIVE - 0x[[FOO_ADDR]]
# CHECK-NEXT: 0x3370 R_X86_64_RELATIVE - 0x3370 # CHECK-NEXT: 0x[[#%X,BAR_ADDR:]] R_X86_64_RELATIVE
# CHECK-NEXT: 0x3378 R_X86_64_RELATIVE - 0x3371 # CHECK-SAME: - 0x[[#BAR_ADDR]]
# CHECK-NEXT: 0x[[#BAR_ADDR + 8]] R_X86_64_RELATIVE - 0x[[#BAR_ADDR + 1]]
# CHECK-NEXT: } # CHECK-NEXT: }
# CHECK-NEXT: ] # CHECK-NEXT: ]
.globl _start .globl _start
_start: _start:
nop nop
.data .data
foo: foo:
.quad foo .quad foo
.hidden bar .hidden bar
.global bar .global bar
bar: bar:
.quad bar .quad bar
.quad bar + 1 .quad bar + 1

lld/test/ELF/relative-dynamic-reloc.s

// REQUIRES: x86 // REQUIRES: x86
// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o // RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
// RUN: ld.lld -shared %t.o -o %t.so // RUN: ld.lld -shared %t.o -o %t.so
// RUN: llvm-readobj --symbols -r --dyn-syms %t.so | FileCheck %s // RUN: llvm-readobj --symbols -r --dyn-syms %t.so | FileCheck %s
// Test that we create R_X86_64_RELATIVE relocations but don't put any // Test that we create R_X86_64_RELATIVE relocations but don't put any
// symbols in the dynamic symbol table. // symbols in the dynamic symbol table.
// CHECK: Relocations [ // CHECK: Relocations [
// CHECK-NEXT: Section ({{.*}}) .rela.dyn { // CHECK-NEXT: Section ({{.*}}) .rela.dyn {
// CHECK-NEXT: 0x[[FOO_ADDR:.*]] R_X86_64_RELATIVE - 0x[[FOO_ADDR]] // CHECK-NEXT: 0x[[FOO_ADDR:.*]] R_X86_64_RELATIVE - 0x[[FOO_ADDR]]
// CHECK-NEXT: 0x[[BAR_ADDR:.*]] R_X86_64_RELATIVE - 0x[[BAR_ADDR]] // CHECK-NEXT: 0x[[#%X,BAR_ADDR:]] R_X86_64_RELATIVE
// CHECK-NEXT: 0x{{[0-9A-F]+}} R_X86_64_RELATIVE - 0x{{[0-9A-F]+}} // CHECK-SAME: - 0x[[#BAR_ADDR]]
// CHECK-NEXT: 0x{{.*}} R_X86_64_RELATIVE - 0x[[ZED_ADDR:.*]] // CHECK-NEXT: 0x[[#BAR_ADDR + 8]] R_X86_64_RELATIVE - 0x[[#BAR_ADDR + 1]]
// CHECK-NEXT: 0x{{.*}} R_X86_64_RELATIVE - 0x[[FOO_ADDR]] // CHECK-NEXT: 0x[[#BAR_ADDR + 16]] R_X86_64_RELATIVE - 0x[[ZED_ADDR:.*]]
// CHECK-NEXT: 0x{{[0-9A-F]+}} R_X86_64_64 external 0x0 // CHECK-NEXT: 0x[[#BAR_ADDR + 24]] R_X86_64_RELATIVE - 0x[[FOO_ADDR]]
// CHECK-NEXT: 0x[[#BAR_ADDR + 32]] R_X86_64_64 external 0x0
// CHECK-NEXT: } // CHECK-NEXT: }
// CHECK-NEXT: ] // CHECK-NEXT: ]
// CHECK: Symbols [ // CHECK: Symbols [
// CHECK: Name: foo // CHECK: Name: foo
// CHECK-NEXT: Value: 0x[[FOO_ADDR]] // CHECK-NEXT: Value: 0x[[FOO_ADDR]]
// CHECK: Name: bar // CHECK: Name: bar
// CHECK-NEXT: Value: 0x[[BAR_ADDR]] // CHECK-NEXT: Value: 0x[[#BAR_ADDR]]
// CHECK: Name: zed // CHECK: Name: zed
// CHECK-NEXT: Value: 0x[[ZED_ADDR]] // CHECK-NEXT: Value: 0x[[ZED_ADDR]]
// CHECK: ] // CHECK: ]
// CHECK: DynamicSymbols [ // CHECK: DynamicSymbols [
// CHECK-NEXT: Symbol { // CHECK-NEXT: Symbol {
// CHECK-NEXT: Name: // CHECK-NEXT: Name:
// CHECK-NEXT: Value: 0x0 // CHECK-NEXT: Value: 0x0
Show All 39 Lines