This is an archive of the discontinued LLVM Phabricator instance.

Differential D111068

[ELF][test][NFC] Make a test standard compliant
ClosedPublic

Authored by ikudrin on Oct 4 2021, 9:05 AM.

Details

Reviewers
MaskRay
grimar
jhenderson
Commits
rG65c284a7be03: [ELF][test][NFC] Make a test standard compliant
Summary

PT_LOAD segments in the program header must be sorted by their virtual addresses, so they should be defined in a similar order as the associated sections.

Diff Detail

Event Timeline

ikudrin created this revision.Oct 4 2021, 9:05 AM
Herald added a subscriber: emaste. · View Herald TranscriptOct 4 2021, 9:05 AM
ikudrin requested review of this revision.Oct 4 2021, 9:05 AM
MaskRay accepted this revision.Oct 4 2021, 5:43 PM

Thanks!

This revision is now accepted and ready to land.Oct 4 2021, 5:43 PM
Closed by commit rG65c284a7be03: [ELF][test][NFC] Make a test standard compliant (authored by ikudrin). · Explain WhyOct 4 2021, 9:40 PM
This revision was automatically updated to reflect the committed changes.
ikudrin added a commit: rG65c284a7be03: [ELF][test][NFC] Make a test standard compliant.

Revision Contents

PathSize
lld/
test/
ELF/
linkerscript/
8 lines

Diff 377084

lld/test/ELF/linkerscript/implicit-program-header.test

# REQUIRES: x86 # REQUIRES: x86
# RUN: echo '.section .text,"ax"; .quad 0' > %t.s # RUN: echo '.section .text,"ax"; .quad 0' > %t.s
# RUN: echo '.section .foo,"ax"; .quad 0' >> %t.s # RUN: echo '.section .foo,"ax"; .quad 0' >> %t.s
# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %t.s -o %t.o # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %t.s -o %t.o
# RUN: ld.lld --hash-style=sysv -o %t1 --script %s %t.o -shared # RUN: ld.lld --hash-style=sysv -o %t1 --script %s %t.o -shared
# RUN: llvm-readelf -l %t1 | FileCheck %s # RUN: llvm-readelf -l %t1 | FileCheck %s
# CHECK: Segment Sections... # CHECK: Segment Sections...
# CHECK-NEXT: 00 .dynsym .hash .dynstr .foo .text .dynamic # CHECK-NEXT: 00 .dynsym .hash .dynstr .text
# CHECK-NEXT: 01 .foo # CHECK-NEXT: 01 .foo .dynamic
# CHECK-NEXT: 02 .foo # CHECK-NEXT: 02 .foo .dynamic
PHDRS { PHDRS {
ph_write PT_LOAD FLAGS(2); ph_write PT_LOAD FLAGS(2);
ph_exec PT_LOAD FLAGS(1); ph_exec PT_LOAD FLAGS(1);
ph_note PT_NOTE; ph_note PT_NOTE;
} }
SECTIONS { SECTIONS {
.text : { *(.text) } : ph_write
.bar : { *(.bar) } : ph_exec : ph_note .bar : { *(.bar) } : ph_exec : ph_note
.foo : { *(.foo) } .foo : { *(.foo) }
.text : { *(.text) } : ph_write
} }