This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Improve help for platform put-file
ClosedPublic

Authored by keith on Oct 1 2021, 5:43 PM.

Details

Summary

Previously it was not clear what arguments this required, or what it would do if you didn't pass the destination argument.

Diff Detail

Event Timeline

keith requested review of this revision.Oct 1 2021, 5:43 PM
keith created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2021, 5:43 PM
labath added a subscriber: labath.Oct 4 2021, 2:49 AM
labath added inline comments.
lldb/source/Commands/CommandObjectPlatform.cpp
1079

It would be more correct to say "the platform working directory" (as selected by platform settings -w).

It might also be nice to mention what happens with relative paths. I guess they are going to be interpreted relative to the remove WD (?)

keith updated this revision to Diff 377010.Oct 4 2021, 12:50 PM
keith marked an inline comment as done.

Update text about resolving paths

labath accepted this revision.Oct 5 2021, 12:48 AM

looks good. thanks.

This revision is now accepted and ready to land.Oct 5 2021, 12:48 AM
This revision was automatically updated to reflect the committed changes.