This is an archive of the discontinued LLVM Phabricator instance.

Differential D110955

[AIX] Don't pass namedsects in LTO mode
ClosedPublic

Authored by jsji on Oct 1 2021, 11:56 AM.

Details

Reviewers
Whitney
Group Reviewers
Restricted Project
Commits
rG9c31969e8df2: [AIX] Don't pass namedsects in LTO mode
Summary

LTO don't need binder option , don't pass it in LTO mode.

Diff Detail

Event Timeline

jsji created this revision.Oct 1 2021, 11:56 AM
Herald added a subscriber: inglorion. · View Herald TranscriptOct 1 2021, 11:56 AM
jsji requested review of this revision.Oct 1 2021, 11:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2021, 11:56 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B126736: Diff 376592.Oct 1 2021, 11:56 AM
Whitney accepted this revision.Oct 1 2021, 12:00 PM
This revision is now accepted and ready to land.Oct 1 2021, 12:00 PM
jsji updated this revision to Diff 376595.Oct 1 2021, 12:11 PM

Update.

Harbormaster completed remote builds in B126737: Diff 376595.Oct 1 2021, 12:11 PM
Closed by commit rG9c31969e8df2: [AIX] Don't pass namedsects in LTO mode (authored by jsji). · Explain WhyOct 1 2021, 12:23 PM
This revision was automatically updated to reflect the committed changes.
jsji added a commit: rG9c31969e8df2: [AIX] Don't pass namedsects in LTO mode.

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
5 lines
test/
Driver/
55 lines

Diff 376603

clang/lib/Driver/ToolChains/AIX.cpp

Show First 20 Lines • Show All 92 Lines • ▼ Show 20 Lines if (Args.hasArg(options::OPT_static))
CmdArgs.push_back("-bnso"); CmdArgs.push_back("-bnso");
// Add options for shared libraries. // Add options for shared libraries.
if (Args.hasArg(options::OPT_shared)) { if (Args.hasArg(options::OPT_shared)) {
CmdArgs.push_back("-bM:SRE"); CmdArgs.push_back("-bM:SRE");
CmdArgs.push_back("-bnoentry"); CmdArgs.push_back("-bnoentry");
} }
// Specify PGO linker option // Specify PGO linker option without LTO
if ((Args.hasFlag(options::OPT_fprofile_arcs, options::OPT_fno_profile_arcs, if (!D.isUsingLTO() &&
(Args.hasFlag(options::OPT_fprofile_arcs, options::OPT_fno_profile_arcs,
false) || false) ||
Args.hasFlag(options::OPT_fprofile_generate, Args.hasFlag(options::OPT_fprofile_generate,
options::OPT_fno_profile_generate, false) || options::OPT_fno_profile_generate, false) ||
Args.hasFlag(options::OPT_fprofile_generate_EQ, Args.hasFlag(options::OPT_fprofile_generate_EQ,
options::OPT_fno_profile_generate, false) || options::OPT_fno_profile_generate, false) ||
Args.hasFlag(options::OPT_fprofile_instr_generate, Args.hasFlag(options::OPT_fprofile_instr_generate,
options::OPT_fno_profile_instr_generate, false) || options::OPT_fno_profile_instr_generate, false) ||
Args.hasFlag(options::OPT_fprofile_instr_generate_EQ, Args.hasFlag(options::OPT_fprofile_instr_generate_EQ,
▲ Show 20 Lines • Show All 183 Lines • Show Last 20 Lines

clang/test/Driver/aix-ld.c

Show First 20 Lines • Show All 643 Lines • ▼ Show 20 Lines
// CHECK-LD64-SHARED: "-lc++" // CHECK-LD64-SHARED: "-lc++"
// CHECK-LD64-SHARED: "-lc++abi" // CHECK-LD64-SHARED: "-lc++abi"
// CHECK-LD64-SHARED: "[[RESOURCE_DIR]]{{/|\\\\}}lib{{/|\\\\}}aix{{/|\\\\}}libclang_rt.builtins-powerpc64.a" // CHECK-LD64-SHARED: "[[RESOURCE_DIR]]{{/|\\\\}}lib{{/|\\\\}}aix{{/|\\\\}}libclang_rt.builtins-powerpc64.a"
// CHECK-LD64-SHARED-NOT: "--as-needed" // CHECK-LD64-SHARED-NOT: "--as-needed"
// CHECK-LD64-SHARED: "-lunwind" // CHECK-LD64-SHARED: "-lunwind"
// CHECK-LD64-SHARED-NOT: "--no-as-needed" // CHECK-LD64-SHARED-NOT: "--no-as-needed"
// CHECK-LD64-SHARED: "-lm" // CHECK-LD64-SHARED: "-lm"
// CHECK-LD64-SHARED: "-lc" // CHECK-LD64-SHARED: "-lc"
// Check powerpc-ibm-aix7.3.0.0, -fprofile-generate
// RUN: %clang -no-canonical-prefixes %s -### 2>&1 \
// RUN: -resource-dir=%S/Inputs/resource_dir \
// RUN: -static \
// RUN: -fprofile-generate\
// RUN: -target powerpc-ibm-aix7.3.0.0 \
// RUN: --sysroot %S/Inputs/aix_ppc_tree \
// RUN: -unwindlib=libunwind \
// RUN: | FileCheck --check-prefix=CHECK-PGO-NON-LTO %s
// CHECK-PGO-NON-LTO-NOT: warning:
// CHECK-PGO-NON-LTO: {{.*}}clang{{(.exe)?}}" "-cc1" "-triple" "powerpc-ibm-aix7.3.0.0"
// CHECK-PGO-NON-LTO: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]"
// CHECK-PGO-NON-LTO: "-isysroot" "[[SYSROOT:[^"]+]]"
// CHECK-PGO-NON-LTO: "{{.*}}ld{{(.exe)?}}"
// CHECK-PGO-NON-LTO: "-bdbg:namedsects"
// CHECK-PGO-NON-LTO: "-b32"
// CHECK-PGO-NON-LTO: "-bpT:0x10000000" "-bpD:0x20000000"
// CHECK-PGO-NON-LTO: "[[SYSROOT]]/usr/lib{{/|\\\\}}crt0.o"
// CHECK-PGO-NON-LTO-NOT: "-lc++"
// CHECK-PGO-NON-LTO-NOT: "-lc++abi"
// CHECK-PGO-NON-LTO: "[[RESOURCE_DIR]]{{/|\\\\}}lib{{/|\\\\}}aix{{/|\\\\}}libclang_rt.builtins-powerpc.a"
// CHECK-PGO-NON-LTO-NOT: "--as-needed"
// CHECK-PGO-NON-LTO-NOT: "-lunwind"
// CHECK-PGO-NON-LTO-NOT: "--no-as-needed"
// CHECK-PGO-NON-LTO-NOT: "-lm"
// CHECK-PGO-NON-LTO: "-lc"
// Check powerpc-ibm-aix7.2.5.3, -fprofile-generate, -flto
// RUN: %clang -no-canonical-prefixes %s -### 2>&1 \
// RUN: -resource-dir=%S/Inputs/resource_dir \
// RUN: -static \
// RUN: -fprofile-generate\
// RUN: -flto\
// RUN: -target powerpc-ibm-aix7.2.5.3 \
// RUN: --sysroot %S/Inputs/aix_ppc_tree \
// RUN: -unwindlib=libunwind \
// RUN: | FileCheck --check-prefix=CHECK-PGO-LTO %s
// CHECK-PGO-LTO-NOT: warning:
// CHECK-PGO-LTO: {{.*}}clang{{(.exe)?}}" "-cc1" "-triple" "powerpc-ibm-aix7.2.5.3"
// CHECK-PGO-LTO: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]"
// CHECK-PGO-LTO: "-isysroot" "[[SYSROOT:[^"]+]]"
// CHECK-PGO-LTO: "{{.*}}ld{{(.exe)?}}"
// CHECK-PGO-LTO-NOT: "-bdbg:namedsects"
// CHECK-PGO-LTO: "-b32"
// CHECK-PGO-LTO: "-bpT:0x10000000" "-bpD:0x20000000"
// CHECK-PGO-LTO: "[[SYSROOT]]/usr/lib{{/|\\\\}}crt0.o"
// CHECK-PGO-LTO-NOT: "-lc++"
// CHECK-PGO-LTO-NOT: "-lc++abi"
// CHECK-PGO-LTO: "[[RESOURCE_DIR]]{{/|\\\\}}lib{{/|\\\\}}aix{{/|\\\\}}libclang_rt.builtins-powerpc.a"
// CHECK-PGO-LTO-NOT: "--as-needed"
// CHECK-PGO-LTO-NOT: "-lunwind"
// CHECK-PGO-LTO-NOT: "--no-as-needed"
// CHECK-PGO-LTO-NOT: "-lm"
// CHECK-PGO-LTO: "-lc"