This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Update return type of vec_popcnt to vector unsigned.
ClosedPublic

Authored by amyk on Oct 1 2021, 7:21 AM.

Details

Summary

This patch updates the vec_popcnt builtins to return vector unsigned,
as defined by the Power Vector Intrinsics Programming Reference.
This patch is NFC and all existing tests pass.

Diff Detail

Event Timeline

amyk requested review of this revision.Oct 1 2021, 7:21 AM
amyk created this revision.
quinnp added a subscriber: quinnp.Oct 1 2021, 12:02 PM

I think the commit message needs to be updated.

This patch updates the vec_popcnt builtins to take a signed int as the second parameter...

Should be: This patch updates the return type of the vec_popcnt builtins to vector unsigned...

Other than that, lgtm.

amyk edited the summary of this revision. (Show Details)Oct 1 2021, 1:00 PM
kamaub added a subscriber: kamaub.Oct 7 2021, 5:00 AM
This comment was removed by kamaub.
kamaub accepted this revision.Oct 7 2021, 5:01 AM

Yeah this LGTM as well, accidentally commented without accepting a moment before.

This revision is now accepted and ready to land.Oct 7 2021, 5:01 AM
This revision was automatically updated to reflect the committed changes.