This is an archive of the discontinued LLVM Phabricator instance.

[llvm-profgen] Fix alignment in preferred based calculation
ClosedPublic

Authored by wenlei on Sep 29 2021, 5:44 PM.

Details

Summary

We used the segment alignment in elf header to assume the loader alignment. However this is incorrect because loader alignment is always the same as page size. If segment needs to be aligned at load time, linker will set aligned address as virtual address in elf header.

Diff Detail

Event Timeline

wenlei created this revision.Sep 29 2021, 5:44 PM
wenlei requested review of this revision.Sep 29 2021, 5:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2021, 5:44 PM
hoy accepted this revision.Sep 29 2021, 9:27 PM

lgtm

This revision is now accepted and ready to land.Sep 29 2021, 9:27 PM
This revision was landed with ongoing or failed builds.Sep 29 2021, 11:05 PM
This revision was automatically updated to reflect the committed changes.