tsan: uninline RacyStacks::operator==

[dvyukov]

Summary

It's only used during race reporting.
There is no point in polluting the main header file with it.

[xgupta]

LGTM, Thanks!

(I accepted it as seems an NFC or cleanup patch).

[dvyukov]

Thanks, Shivam.

compiler-rt/lib/tsan/rtl/tsan_rtl.h

public:
   void OnStarted(void *arg) override;
   void OnCreated(void *arg) override;
   void OnReset() override;
   void OnDetached(void *arg) override;
 };
 
 struct RacyStacks {
   MD5Hash hash[2];
-  bool operator==(const RacyStacks &other) const {
-    if (hash[0] == other.hash[0] && hash[1] == other.hash[1])
-      return true;
-    if (hash[0] == other.hash[1] && hash[1] == other.hash[0])
-      return true;
-    return false;
-  }
+  bool operator==(const RacyStacks &other) const;
 };
 
 struct RacyAddress {
   uptr addr_min;
   uptr addr_max;
 };
 
 struct FiredSuppression {

compiler-rt/lib/tsan/rtl/tsan_rtl_report.cpp

TraceReplay(
         }
       });
   ExtractTagFromStack(pstk, ptag);
   return found;
 }
 
 }  // namespace v3
 
+bool RacyStacks::operator==(const RacyStacks &other) const {
+  if (hash[0] == other.hash[0] && hash[1] == other.hash[1])
+    return true;
+  if (hash[0] == other.hash[1] && hash[1] == other.hash[0])
+    return true;
+  return false;
+}
+
 static bool FindRacyStacks(const RacyStacks &hash) {
   for (uptr i = 0; i < ctx->racy_stacks.Size(); i++) {
     if (hash == ctx->racy_stacks[i]) {
       VPrintf(2, "ThreadSanitizer: suppressing report as doubled (stack)\n");
       return true;
     }
   }
   return false;