This is an archive of the discontinued LLVM Phabricator instance.

Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c test case.
ClosedPublic

Authored by amyk on Sep 24 2021, 10:15 AM.

Details

Summary

It appears that this test assumes that the toolchain utilizes the integrated assembler by default,
since the expected output in the CHECKs are compilation_database.o.

However, this test fails on AIX as AIX does not utilize the integrated assembler. On AIX, the output
instead is of the form /tmp/compilation_database-*.s. Thus, this patch explicitly adds the
-fintegrated-as option to match the assumption that the integrated assembler is used by default.

Diff Detail

Event Timeline

amyk requested review of this revision.Sep 24 2021, 10:15 AM
amyk created this revision.
daltenty accepted this revision.Sep 24 2021, 10:30 AM

LGTM (without the integrated assembler there will be an assembler invocation in the compilation database that actually produces the .o instead of the clang invocation we are looking for)

This revision is now accepted and ready to land.Sep 24 2021, 10:30 AM
This revision was landed with ongoing or failed builds.Sep 27 2021, 7:56 AM
This revision was automatically updated to reflect the committed changes.