This change is part of a series of commits dedicated to have a single
DataLayout during compilation by using always the one owned by the
module.
Details
Diff Detail
Event Timeline
lib/CodeGen/TargetLoweringBase.cpp | ||
---|---|---|
882 | Why can't this use getDataLayout? |
What about also making getPointerTy() define in the header, it is non-virtual and can be inlined.
I'm also not sure why it has to be in this class, it seems it could be a free function?
One inline question...
-eric
include/llvm/CodeGen/BasicTTIImpl.h | ||
---|---|---|
149 | My C++ knowledge may be lacking here, but why can't we use getDataLayout here? |
include/llvm/CodeGen/BasicTTIImpl.h | ||
---|---|---|
149 | C++ weirdness explained here: https://isocpp.org/wiki/faq/templates#nondependent-name-lookup-members Now, we could also write this->DL. But I may be better adding a using TargetTransformInfoImplBase::DL in the class itself instead of clobbering every single use. |
LGTM.
I have no preference on reorganizing getPointerTy.
-eric
include/llvm/CodeGen/BasicTTIImpl.h | ||
---|---|---|
149 | *sigh* Right. OK. Thanks! |
My C++ knowledge may be lacking here, but why can't we use getDataLayout here?