This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove uses of _LIBCPP_HAS_NO_VARIABLE_TEMPLATES
ClosedPublic

Authored by ldionne on Sep 22 2021, 1:05 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG1711a6ec6509: [libc++] Remove uses of _LIBCPP_HAS_NO_VARIABLE_TEMPLATES
Summary

All supported compilers provide support for variable templates now.

Diff Detail

Event Timeline

ldionne requested review of this revision.Sep 22 2021, 1:05 PM
ldionne created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2021, 1:05 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
jloser added a subscriber: jloser.Sep 22 2021, 1:11 PM
jloser added inline comments.
libcxx/test/libcxx/selftest/test_macros.pass.cpp
33

Now that this function is empty, can we just remove it and its call site in main below?

ldionne updated this revision to Diff 374349.Sep 22 2021, 1:25 PM
ldionne marked an inline comment as done.

Address review comments.

libcxx/test/libcxx/selftest/test_macros.pass.cpp
33

I was going to leave it as-is in case we re-add some in the future, but yeah, I agree with you. I'll remove it.

LGTM. I'm happy if CI passes.

ldionne accepted this revision.Sep 23 2021, 5:53 AM

Build passed but there was an error updating the Phab status. CI has been unreliable for the past week.

This revision is now accepted and ready to land.Sep 23 2021, 5:53 AM
This revision was landed with ongoing or failed builds.Sep 23 2021, 5:54 AM
This revision was automatically updated to reflect the committed changes.