Details
- Reviewers
eugenis
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
compiler-rt/lib/hwasan/hwasan.cpp | ||
---|---|---|
451 | I think you need to update CheckAddress - it only ever checks the first granule. And it would be great to have a runtime test that ex. 64-byte access checks the middle and the last granules. | |
llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp | ||
74 | rename it to something like kApi32NumberOfAccessSizes. "old" is too vague. | |
1049 | as I understand, this will work for 64-byte access that is only 16-byte aligned. Could you add a test for this? |
I think you need to update CheckAddress - it only ever checks the first granule.
And it would be great to have a runtime test that ex. 64-byte access checks the middle and the last granules.