[clang] Make -Rpass imply -Rpass=.*

[aeubanks]

Summary

Previously with -Rpass (and friends) we'd have remarks "enabled", but
without an actual regex.

As seen in the test change to line numbers, this can give us better
diagnostics by properly enabling NeedLocTracking with -Rpass.

[dblaikie]

Great!

clang/lib/Frontend/CompilerInvocation.cpp

 /// Parse a remark command line argument. It may be missing, disabled/enabled by
 /// '-R[no-]group' or specified with a regular expression by '-Rgroup=regexp'.
 /// On top of that, it can be disabled/enabled globally by '-R[no-]everything'.
 static CodeGenOptions::OptRemark
 ParseOptimizationRemark(DiagnosticsEngine &Diags, ArgList &Args,
                         OptSpecifier OptEQ, StringRef Name) {
   CodeGenOptions::OptRemark Result;
 
-  auto InitializeResultPattern = [&Diags, &Args, &Result](const Arg *A) {
-    Result.Pattern = A->getValue();
+  auto InitializeResultPattern = [&Diags, &Args, &Result](const Arg *A,
+                                                          StringRef Pattern) {
+    Result.Pattern = Pattern.str();
 
     std::string RegexError;
     Result.Regex = std::make_shared<llvm::Regex>(Result.Pattern);
     if (!Result.Regex->isValid(RegexError)) {
       Diags.Report(diag::err_drv_optimization_remark_pattern)
           << RegexError << A->getAsString(Args);
       return false;
     }
 
     return true;
   };
 
   for (Arg *A : Args) {
     if (A->getOption().matches(OPT_R_Joined)) {
       StringRef Value = A->getValue();
 
       if (Value == Name)
         Result.Kind = CodeGenOptions::RK_Enabled;
       else if (Value == "everything")
         Result.Kind = CodeGenOptions::RK_EnabledEverything;
       else if (Value.split('-') == std::make_pair(StringRef("no"), Name))
         Result.Kind = CodeGenOptions::RK_Disabled;
       else if (Value == "no-everything")
         Result.Kind = CodeGenOptions::RK_DisabledEverything;
-    } else if (A->getOption().matches(OptEQ)) {
-      Result.Kind = CodeGenOptions::RK_WithPattern;
-      if (!InitializeResultPattern(A))
-        return CodeGenOptions::OptRemark();
-    }
-  }
 
       if (Result.Kind == CodeGenOptions::RK_Disabled ||
           Result.Kind == CodeGenOptions::RK_DisabledEverything) {
         Result.Pattern = "";
         Result.Regex = nullptr;
+      } else {
+        InitializeResultPattern(A, ".*");
+      }
+    } else if (A->getOption().matches(OptEQ)) {
+      Result.Kind = CodeGenOptions::RK_WithPattern;
+      if (!InitializeResultPattern(A, A->getValue()))
+        return CodeGenOptions::OptRemark();
+    }
   }
 
   return Result;
 }
 
 static bool parseDiagnosticLevelMask(StringRef FlagName,
                                      const std::vector<std::string> &Levels,
                                      DiagnosticsEngine &Diags,

clang/test/Frontend/optimization-remark-analysis.c

 // RUN: %clang -O1 -fvectorize -target x86_64-unknown-unknown -emit-llvm -Rpass-analysis -S %s -o - 2>&1 | FileCheck %s --check-prefix=RPASS
 // RUN: %clang -O1 -fvectorize -target x86_64-unknown-unknown -emit-llvm -S %s -o - 2>&1 | FileCheck %s
 
-// RPASS: {{.*}}:7:8: remark: loop not vectorized: loop contains a switch statement
-// CHECK-NOT: {{.*}}:7:8: remark: loop not vectorized: loop contains a switch statement
+// RPASS: {{.*}}:12:5: remark: loop not vectorized: loop contains a switch statement
+// CHECK-NOT: remark: loop not vectorized: loop contains a switch statement
 
 double foo(int N, int *Array) {
   double v = 0.0;
 
   #pragma clang loop vectorize(enable)
   for (int i = 0; i < N; i++) {
     switch(Array[i]) {
     case 0: v += 1.0f; break;
     case 1: v -= 0.5f; break;
     case 2: v *= 2.0f; break;
     default: v = 0.0f;
     }
   }
 
   return v;
 }

clang/test/Frontend/optimization-remark.c

 // get the same remarks with at least O1.
 // RUN: %clang_cc1 %s -Rpass=inline -fexperimental-new-pass-manager -O1 -emit-llvm -mllvm -mandatory-inlining-first=false -o - 2>&1 | FileCheck %s --check-prefix=CHECK-REMARKS
 // RUN: %clang_cc1 %s -Rpass=inline -fexperimental-new-pass-manager -O1 -Rno-everything -Reverything -emit-llvm -mllvm -mandatory-inlining-first=false -o -  2>&1 | FileCheck %s --check-prefix=CHECK-REMARKS
 //
 // Check that -w doesn't disable remarks.
 // RUN: %clang_cc1 %s -Rpass=inline -fno-experimental-new-pass-manager -w -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=CHECK-REMARKS
 // RUN: %clang_cc1 %s -Rpass=inline -fexperimental-new-pass-manager -O1 -w -emit-llvm -mllvm -mandatory-inlining-first=false -o - 2>&1 | FileCheck %s --check-prefix=CHECK-REMARKS
 //
-// FIXME: -Reverything should imply -Rpass=.*.
-// RUN: %clang_cc1 %s -Reverything -emit-llvm -o - 2>/dev/null | FileCheck %s --check-prefix=CHECK-NO-REMARKS
+// -Reverything implies -Rpass=.*.
+// RUN: %clang_cc1 %s -Reverything -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=CHECK-REMARKS
 //
-// FIXME: -Rpass should either imply -Rpass=.* or should be rejected.
-// RUN: %clang_cc1 %s -Rpass -emit-llvm -o - 2>/dev/null | FileCheck %s --check-prefix=CHECK-NO-REMARKS
+// -Rpass implies -Rpass=.*
+// RUN: %clang_cc1 %s -Rpass -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=CHECK-REMARKS
 
 // CHECK-REMARKS: remark:
 // CHECK-NO-REMARKS-NOT: remark:
 
 // -Rpass should produce source location annotations, exclusively (just
 // like -gmlt).
 // CHECK: , !dbg !
 // CHECK-NOT: DW_TAG_base_type