This is an archive of the discontinued LLVM Phabricator instance.

[zorg] Reorganize Polly builders.
ClosedPublic

Authored by Meinersbur on Sep 19 2021, 6:15 PM.

Details

Summary

Instead of a single build configuration, add 6 builders of the configurations (static, shared, shlib) x (LINK_POLLY_INTO_TOOLS=ON/OFF) for the 2 gce buildsbots. The test-suite build is extended to include external tests (SPEC benchmarks, povray) and moved to 2 other workers that should be able to compile it faster. Also, the verbosity is reduced (seems to have caused problem when the buildbot master receives too much data) and -polly-process-unprofitable is used for greater test coverage.

Build configurations already running here:
http://meinersbur.de:8011/#/builders/83
http://meinersbur.de:8011/#/builders/145
http://meinersbur.de:8011/#/builders/149
http://meinersbur.de:8011/#/builders/148
http://meinersbur.de:8011/#/builders/147
http://meinersbur.de:8011/#/builders/146
http://meinersbur.de:8011/#/builders/76

Event Timeline

Meinersbur created this revision.Sep 19 2021, 6:15 PM
Meinersbur requested review of this revision.Sep 19 2021, 6:15 PM
gkistanova requested changes to this revision.Oct 14 2021, 9:19 AM

Thanks for the patch, Michael!

zorg/buildbot/builders/PollyBuilder.py
16

Wrong indentation?

17

Instead of adding a Boolean argument and then handling it to set a cmake parameter, why not let user expliciltly set the
-DPOLLY_ENABLE_GPGPU_CODEGEN in the existing
extraCmakeArgs argument, and add the default if not set explicitly?

86–89

Missing comma and new line between env and logfiles?

163

This effectively prohibits using interpolation with testsuiteComplileArgs.

You ether do interpolation here, for example by calling WithProperties on test suite arguments, or you need to build the flags differently.

This revision now requires changes to proceed.Oct 14 2021, 9:19 AM
Meinersbur marked 3 inline comments as done.
  • Address review
  • Sort builders by -fPIC
Meinersbur added inline comments.Oct 15 2021, 10:49 AM
zorg/buildbot/builders/PollyBuilder.py
16

Was using tab indentation here. I should use spaces consistently.

17

I moved the POLLY_ENABLE_GPGPU_CODEGEN configuration parameters to the builders, does not introduce additional complexity. Some of the build seem to have set POLLY_ENABLE_GPGPU_CODEGEN already in order to override it.

163

Removing extraTestsuiteCompileArgs. I think I had a use case of it, but it is not used in this patch.

Meinersbur marked an inline comment as done.Oct 15 2021, 10:49 AM
gkistanova accepted this revision.Oct 15 2021, 1:18 PM

Thanks, Michael!

LGTM.

If you want, you can set -DPOLLY_ENABLE_GPGPU_CODEGEN=OFF by default in PollyBuilder by using CmakeCommand.ApplyDefaultOptions.

This revision is now accepted and ready to land.Oct 15 2021, 1:18 PM
This revision now requires review to proceed.Oct 17 2021, 3:59 AM
ineedanaccountpronto changed the visibility from "Public (No Login Required)" to "ineedanaccountpronto (Jimmy Fish)".Oct 17 2021, 4:20 AM
ineedanaccountpronto changed the visibility from "ineedanaccountpronto (Jimmy Fish)" to "All Users".
ineedanaccountpronto changed the edit policy from "All Users" to "ineedanaccountpronto (Jimmy Fish)".
ineedanaccountpronto changed the visibility from "All Users" to "Public (No Login Required)".
ineedanaccountpronto changed the edit policy from "ineedanaccountpronto (Jimmy Fish)" to "All Users".
This revision was not accepted when it landed; it landed in state Needs Review.Oct 18 2021, 10:16 AM
This revision was automatically updated to reflect the committed changes.