This is an archive of the discontinued LLVM Phabricator instance.

Differential D110002

[flang] Put intrinsic function table back into order
ClosedPublic

Authored by klausler on Sep 17 2021, 2:03 PM.

Details

Reviewers
jeanPerier
Commits
rG5661317f864a: [flang] Put intrinsic function table back into order
Summary

Some intrinsic functions weren't findable because the table
wasn't strictly in order of names.

And complete a missing generalization of the extension DCONJG
to accept any kind of complex argument, like DREAL and DIMAG
were.

Diff Detail

Event Timeline

klausler created this revision.Sep 17 2021, 2:03 PM
Herald added a subscriber: jdoerfert. · View Herald TranscriptSep 17 2021, 2:03 PM
klausler requested review of this revision.Sep 17 2021, 2:03 PM
Harbormaster completed remote builds in B124477: Diff 373330.Sep 17 2021, 2:40 PM
jeanPerier accepted this revision.Sep 20 2021, 12:19 AM
This revision is now accepted and ready to land.Sep 20 2021, 12:19 AM
Closed by commit rG5661317f864a: [flang] Put intrinsic function table back into order (authored by klausler). · Explain WhySep 20 2021, 8:40 AM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG5661317f864a: [flang] Put intrinsic function table back into order.
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2021, 8:40 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
flang/
lib/
Evaluate/
9 lines
unittests/
Evaluate/
4 lines

Diff 373606

flang/lib/Evaluate/intrinsics.cpp

Show First 20 Lines • Show All 930 Lines • ▼ Show 20 Linesstatic const SpecificIntrinsicInterface specificIntrinsicFunction[]{
DoublePrecision}, DoublePrecision},
"atan2"}, "atan2"},
{{"dcmplx", {{"x", AnyComplex}}, DoublePrecisionComplex}, "cmplx", true}, {{"dcmplx", {{"x", AnyComplex}}, DoublePrecisionComplex}, "cmplx", true},
{{"dcmplx", {{"dcmplx",
{{"x", AnyIntOrReal, Rank::elementalOrBOZ}, {{"x", AnyIntOrReal, Rank::elementalOrBOZ},
{"y", AnyIntOrReal, Rank::elementalOrBOZ, Optionality::optional}}, {"y", AnyIntOrReal, Rank::elementalOrBOZ, Optionality::optional}},
DoublePrecisionComplex}, DoublePrecisionComplex},
"cmplx", true}, "cmplx", true},
{{"dfloat", {{"i", AnyInt}}, DoublePrecision}, "real", true}, {{"dconjg", {{"a", AnyComplex}}, DoublePrecisionComplex}, "conjg"},
{{"dreal", {{"a", AnyComplex}}, DoublePrecision}, "real", true},
{{"dconjg", {{"a", DoublePrecisionComplex}}, DoublePrecisionComplex},
"conjg"},
{{"dcos", {{"x", DoublePrecision}}, DoublePrecision}, "cos"}, {{"dcos", {{"x", DoublePrecision}}, DoublePrecision}, "cos"},
{{"dcosh", {{"x", DoublePrecision}}, DoublePrecision}, "cosh"}, {{"dcosh", {{"x", DoublePrecision}}, DoublePrecision}, "cosh"},
{{"ddim", {{"x", DoublePrecision}, {"y", DoublePrecision}}, {{"ddim", {{"x", DoublePrecision}, {"y", DoublePrecision}},
DoublePrecision}, DoublePrecision},
"dim"}, "dim"},
{{"dimag", {{"a", DoublePrecisionComplex}}, DoublePrecision}, "aimag"},
{{"dexp", {{"x", DoublePrecision}}, DoublePrecision}, "exp"}, {{"dexp", {{"x", DoublePrecision}}, DoublePrecision}, "exp"},
{{"dfloat", {{"i", AnyInt}}, DoublePrecision}, "real", true},
{{"dim", {{"x", DefaultReal}, {"y", DefaultReal}}, DefaultReal}}, {{"dim", {{"x", DefaultReal}, {"y", DefaultReal}}, DefaultReal}},
{{"dimag", {{"a", AnyComplex}}, DoublePrecision}, "aimag"},
{{"dint", {{"a", DoublePrecision}}, DoublePrecision}, "aint"}, {{"dint", {{"a", DoublePrecision}}, DoublePrecision}, "aint"},
{{"dlog", {{"x", DoublePrecision}}, DoublePrecision}, "log"}, {{"dlog", {{"x", DoublePrecision}}, DoublePrecision}, "log"},
{{"dlog10", {{"x", DoublePrecision}}, DoublePrecision}, "log10"}, {{"dlog10", {{"x", DoublePrecision}}, DoublePrecision}, "log10"},
{{"dmax1", {{"dmax1",
{{"a1", DoublePrecision}, {"a2", DoublePrecision}, {{"a1", DoublePrecision}, {"a2", DoublePrecision},
{"a3", DoublePrecision, Rank::elemental, Optionality::repeats}}, {"a3", DoublePrecision, Rank::elemental, Optionality::repeats}},
DoublePrecision}, DoublePrecision},
"max", true, true}, "max", true, true},
{{"dmin1", {{"dmin1",
{{"a1", DoublePrecision}, {"a2", DoublePrecision}, {{"a1", DoublePrecision}, {"a2", DoublePrecision},
{"a3", DoublePrecision, Rank::elemental, Optionality::repeats}}, {"a3", DoublePrecision, Rank::elemental, Optionality::repeats}},
DoublePrecision}, DoublePrecision},
"min", true, true}, "min", true, true},
{{"dmod", {{"a", DoublePrecision}, {"p", DoublePrecision}}, {{"dmod", {{"a", DoublePrecision}, {"p", DoublePrecision}},
DoublePrecision}, DoublePrecision},
"mod"}, "mod"},
{{"dnint", {{"a", DoublePrecision}}, DoublePrecision}, "anint"}, {{"dnint", {{"a", DoublePrecision}}, DoublePrecision}, "anint"},
{{"dprod", {{"x", DefaultReal}, {"y", DefaultReal}}, DoublePrecision}}, {{"dprod", {{"x", DefaultReal}, {"y", DefaultReal}}, DoublePrecision}},
{{"dreal", {{"a", AnyComplex}}, DoublePrecision}, "real", true},
{{"dsign", {{"a", DoublePrecision}, {"b", DoublePrecision}}, {{"dsign", {{"a", DoublePrecision}, {"b", DoublePrecision}},
DoublePrecision}, DoublePrecision},
"sign"}, "sign"},
{{"dsin", {{"x", DoublePrecision}}, DoublePrecision}, "sin"}, {{"dsin", {{"x", DoublePrecision}}, DoublePrecision}, "sin"},
{{"dsinh", {{"x", DoublePrecision}}, DoublePrecision}, "sinh"}, {{"dsinh", {{"x", DoublePrecision}}, DoublePrecision}, "sinh"},
{{"dsqrt", {{"x", DoublePrecision}}, DoublePrecision}, "sqrt"}, {{"dsqrt", {{"x", DoublePrecision}}, DoublePrecision}, "sqrt"},
{{"dtan", {{"x", DoublePrecision}}, DoublePrecision}, "tan"}, {{"dtan", {{"x", DoublePrecision}}, DoublePrecision}, "tan"},
{{"dtanh", {{"x", DoublePrecision}}, DoublePrecision}, "tanh"}, {{"dtanh", {{"x", DoublePrecision}}, DoublePrecision}, "tanh"},
▲ Show 20 Lines • Show All 1,551 Lines • Show Last 20 Lines

flang/unittests/Evaluate/intrinsics.cpp

Show First 20 Lines • Show All 231 Lines • ▼ Show 20 Linesvoid TestIntrinsics() {
amin1ExtCall.DoCall(Real4::GetType()); amin1ExtCall.DoCall(Real4::GetType());
TestCall{defaults, table, "conjg"} TestCall{defaults, table, "conjg"}
.Push(Const(Scalar<Complex4>{})) .Push(Const(Scalar<Complex4>{}))
.DoCall(Complex4::GetType()); .DoCall(Complex4::GetType());
TestCall{defaults, table, "conjg"} TestCall{defaults, table, "conjg"}
.Push(Const(Scalar<Complex8>{})) .Push(Const(Scalar<Complex8>{}))
.DoCall(Complex8::GetType()); .DoCall(Complex8::GetType());
TestCall{defaults, table, "dconjg"}.Push(Const(Scalar<Complex4>{})).DoCall(); TestCall{defaults, table, "dconjg"}
.Push(Const(Scalar<Complex4>{}))
.DoCall(Complex8::GetType());
TestCall{defaults, table, "dconjg"} TestCall{defaults, table, "dconjg"}
.Push(Const(Scalar<Complex8>{})) .Push(Const(Scalar<Complex8>{}))
.DoCall(Complex8::GetType()); .DoCall(Complex8::GetType());
TestCall{defaults, table, "float"}.Push(Const(Scalar<Real4>{})).DoCall(); TestCall{defaults, table, "float"}.Push(Const(Scalar<Real4>{})).DoCall();
TestCall{defaults, table, "float"} TestCall{defaults, table, "float"}
.Push(Const(Scalar<Int4>{})) .Push(Const(Scalar<Int4>{}))
.DoCall(Real4::GetType()); .DoCall(Real4::GetType());
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines