This is an archive of the discontinued LLVM Phabricator instance.

Support Unicode 14 identifiers
ClosedPublic

Authored by cor3ntin on Sep 15 2021, 2:23 PM.

Details

Reviewers
aaron.ballman
Summary

This update the UAX tables to support new Unicode 14 identifiers

Diff Detail

Event Timeline

cor3ntin requested review of this revision.Sep 15 2021, 2:23 PM
cor3ntin created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2021, 2:23 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
cor3ntin retitled this revision from Support Unicode 14 identifiers This update the UAX tables to support new Unicode 14 identifiers to Support Unicode 14 identifiers.Sep 16 2021, 5:22 AM
cor3ntin edited the summary of this revision. (Show Details)
cor3ntin added a reviewer: aaron.ballman.

Thanks for this! Can you add a test case that shows we now accept some Unicode 14 characters that Clang previously would have rejected (with a comment explaining what's being tested)?

clang/lib/Lex/UnicodeCharSets.h
13

Looks like this comment needs to be updated.

217–235

This comment needs updating as well.

cor3ntin updated this revision to Diff 372915.Sep 16 2021, 6:14 AM

Added some tests for randomly choosen Unicode 14
codepoints

aaron.ballman accepted this revision.Sep 16 2021, 7:15 AM

LGTM with a minor comment on comments that I'll handle when I land this.

clang/test/Lexer/unicode.c
37–41

When I land this, I'm going to add extra whitespace between the comment marker and the comment content.

This revision is now accepted and ready to land.Sep 16 2021, 7:15 AM

I committed this on your behalf in afb6223bc53034973379863d08cbee322149569e, thanks!