This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Move -fno-omit-frame-pointer check to common config-ix
ClosedPublic

Authored by mgorny on Sep 15 2021, 1:28 AM.

Details

Summary

9ee64c374605683ae80b9641d5312a72c2a67336 has started using
COMPILER_RT_HAS_OMIT_FRAME_POINTER_FLAG inside scudo. However,
the relevant CMake check was performed in builtin-config-ix.cmake,
so the definition was missing when builtins were not built. Move
the check to config-ix.cmake, so that it runs unconditionally of
the components being built.

Fixes PR#51847

Diff Detail

Event Timeline

mgorny created this revision.Sep 15 2021, 1:28 AM
mgorny requested review of this revision.Sep 15 2021, 1:28 AM
tstellar accepted this revision.Sep 15 2021, 8:00 AM

LGTM. Thank you.

This revision is now accepted and ready to land.Sep 15 2021, 8:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2021, 9:32 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript