This is an archive of the discontinued LLVM Phabricator instance.

[runtimes] Check whether -nostdinc++ and -nostdlib++ are supported
ClosedPublic

Authored by mstorsjo on Sep 13 2021, 1:07 PM.

Details

Summary

Don't blindly assume they're supported - GCC doesn't support -nostdlib++.

The llvm-project/runtimes directory is supposed to allow building the
runtimes standalone from a newly built Clang, and thus should allow
building with other compilers too.

Diff Detail

Event Timeline

mstorsjo created this revision.Sep 13 2021, 1:07 PM
mstorsjo requested review of this revision.Sep 13 2021, 1:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2021, 1:07 PM
mstorsjo updated this revision to Diff 372415.Sep 14 2021, 12:17 AM

Reorder the checks to let -nostdlib++ take effect first, as it affects whether other checks succeed or not.

phosek accepted this revision.Sep 14 2021, 2:03 AM

LGTM

This revision is now accepted and ready to land.Sep 14 2021, 2:03 AM
mstorsjo updated this revision to Diff 372439.Sep 14 2021, 2:07 AM

Reuploading with a dummy change under libcxx, to trigger rerunning the libcxx premerge tests with this change, will remove that before pushing.

Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2021, 2:07 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
This revision now requires review to proceed.Sep 14 2021, 2:07 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 14 2021, 3:43 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.