This is an archive of the discontinued LLVM Phabricator instance.

[CFGPrinter] Fix CFGPrinter that specifying function names does not work
AbandonedPublic

Authored by congzhe on Sep 10 2021, 1:58 PM.

Download Raw Diff

Details

Reviewers: None

Summary

The option that -view-cfg -cfg-func-name=<string> is supposed to print the cfg only for function with names contained in <string>, but currently it does not work and all functions in the IR will be printed out which causes inconvenience.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

congzhe created this revision.Sep 10 2021, 1:58 PM

Herald added a subscriber: hiraditya. · View Herald TranscriptSep 10 2021, 1:58 PM

congzhe requested review of this revision.Sep 10 2021, 1:58 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2021, 1:58 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B123507: Diff 372009.Sep 10 2021, 2:05 PM

Looks like a similar fix has been committed before.

Revision Contents

Path

Size

llvm/

lib/

Analysis/

CFGPrinter.cpp

2 lines

Diff 372009

llvm/lib/Analysis/CFGPrinter.cpp

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Lines	static void writeCFGToDotFile(Function &F, BlockFrequencyInfo *BFI,
else		else
errs() << " error opening file for writing!";		errs() << " error opening file for writing!";
errs() << "\n";		errs() << "\n";
}		}

static void viewCFG(Function &F, const BlockFrequencyInfo *BFI,		static void viewCFG(Function &F, const BlockFrequencyInfo *BFI,
const BranchProbabilityInfo *BPI, uint64_t MaxFreq,		const BranchProbabilityInfo *BPI, uint64_t MaxFreq,
bool CFGOnly = false) {		bool CFGOnly = false) {
		if (!CFGFuncName.emtpy() && !F.getName().contains(CFGFuncName))
		Lint: Pre-merge checks Inline Actions clang-tidy: error: no member named 'emtpy' in 'llvm::cl::opt<std::string>' [clang-diagnostic-error] not useful Lint: Pre-merge checks: clang-tidy: error: no member named 'emtpy' in 'llvm::cl::opt<std::string>' [clang-diagnostic…
		return;
		Lint: Pre-merge checks Inline Actions clang-format: please reformat the code - return; + return; Lint: Pre-merge checks: clang-format: please reformat the code ``` - return; + return; ```
DOTFuncInfo CFGInfo(&F, BFI, BPI, MaxFreq);		DOTFuncInfo CFGInfo(&F, BFI, BPI, MaxFreq);
CFGInfo.setHeatColors(ShowHeatColors);		CFGInfo.setHeatColors(ShowHeatColors);
CFGInfo.setEdgeWeights(ShowEdgeWeight);		CFGInfo.setEdgeWeights(ShowEdgeWeight);
CFGInfo.setRawEdgeWeights(UseRawEdgeWeight);		CFGInfo.setRawEdgeWeights(UseRawEdgeWeight);

ViewGraph(&CFGInfo, "cfg." + F.getName(), CFGOnly);		ViewGraph(&CFGInfo, "cfg." + F.getName(), CFGOnly);
}		}

▲ Show 20 Lines • Show All 240 Lines • Show Last 20 Lines