This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Fix format string in Communication::Write
ClosedPublic

Authored by rmansfield on Sep 9 2021, 7:15 AM.

Reviewers

JDevlieghere
teemperor

Commits

rmansfield requested review of this revision.Sep 9 2021, 7:15 AM

rmansfield created this revision.

Thanks, LGTM

This revision is now accepted and ready to land.Sep 9 2021, 7:20 AM

Thanks. Could someone please apply on my behalf?

This revision was landed with ongoing or failed builds.Sep 9 2021, 8:56 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

source/

Core/

4 lines

	Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines
	}			}

	size_t Communication::Write(const void *src, size_t src_len,			size_t Communication::Write(const void *src, size_t src_len,
	ConnectionStatus &status, Status *error_ptr) {			ConnectionStatus &status, Status *error_ptr) {
	lldb::ConnectionSP connection_sp(m_connection_sp);			lldb::ConnectionSP connection_sp(m_connection_sp);

	std::lock_guard<std::mutex> guard(m_write_mutex);			std::lock_guard<std::mutex> guard(m_write_mutex);
	LLDB_LOG(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_COMMUNICATION),			LLDB_LOG(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_COMMUNICATION),
	"{0} Communication::Write (src = {1}, src_len = %" PRIu64			"{0} Communication::Write (src = {1}, src_len = {2}"
	") connection = {2}",			") connection = {3}",
	this, src, (uint64_t)src_len, connection_sp.get());			this, src, (uint64_t)src_len, connection_sp.get());

	if (connection_sp)			if (connection_sp)
	return connection_sp->Write(src, src_len, status, error_ptr);			return connection_sp->Write(src, src_len, status, error_ptr);

	if (error_ptr)			if (error_ptr)
	error_ptr->SetErrorString("Invalid connection.");			error_ptr->SetErrorString("Invalid connection.");
	status = eConnectionStatusNoConnection;			status = eConnectionStatusNoConnection;
	▲ Show 20 Lines • Show All 251 Lines • Show Last 20 Lines