This is an archive of the discontinued LLVM Phabricator instance.

Differential D109470

Add "profiling" to the list of absl libraries.
ClosedPublic

Authored by nilayvaish on Sep 8 2021, 3:32 PM.

Details

Reviewers
ymandel
Commits
rGe976fc61ecd9: Add "profiling" to the list of absl libraries.

Diff Detail

Event Timeline

nilayvaish requested review of this revision.Sep 8 2021, 3:32 PM
nilayvaish created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 8 2021, 3:32 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
nilayvaish added a reviewer: ymandel.Sep 8 2021, 3:37 PM
Harbormaster completed remote builds in B123129: Diff 371461.Sep 8 2021, 4:13 PM
ymandel accepted this revision.Sep 9 2021, 10:13 AM

Any idea if there's a test for this matcher that should be updated?

This revision is now accepted and ready to land.Sep 9 2021, 10:13 AM
nilayvaish added a comment.Sep 9 2021, 10:24 AM
In D109470#2992119, @ymandel wrote:

Any idea if there's a test for this matcher that should be updated?

I looked at the commit that most recently added a directory to this file: 114c9fa0e46f7bf1d05d92da70da116b19f16911. That one also did not update any tests. I also looked for isInAbseilFile in the clang-tools-extra directory. I did not find the function being used in any of the tests.

ymandel added a comment.Sep 9 2021, 10:35 AM
In D109470#2992161, @nilayvaish wrote:
In D109470#2992119, @ymandel wrote:

Any idea if there's a test for this matcher that should be updated?

I looked at the commit that most recently added a directory to this file: 114c9fa0e46f7bf1d05d92da70da116b19f16911. That one also did not update any tests. I also looked for isInAbseilFile in the clang-tools-extra directory. I did not find the function being used in any of the tests.

Yeah, that was my impression as well. Alas. In that case, I think it's fine to commit as is. Thanks!

nilayvaish added a comment.Sep 9 2021, 11:18 AM

ymandel@, I do not have commit access to the repo. Can you commit this for me? Thanks!

ymandel added a comment.Sep 9 2021, 12:08 PM
In D109470#2992275, @nilayvaish wrote:

ymandel@, I do not have commit access to the repo. Can you commit this for me? Thanks!

Sure!

Closed by commit rGe976fc61ecd9: Add "profiling" to the list of absl libraries. (authored by nilayvaish, committed by ymandel). · Explain WhySep 9 2021, 1:31 PM
This revision was automatically updated to reflect the committed changes.
ymandel added a commit: rGe976fc61ecd9: Add "profiling" to the list of absl libraries..

Revision Contents

PathSize
clang-tools-extra/
clang-tidy/
abseil/
14 lines

Diff 371708

clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 LinesAST_POLYMORPHIC_MATCHER(
// Determine whether filepath contains "absl/[absl-library]" substring, where // Determine whether filepath contains "absl/[absl-library]" substring, where
// [absl-library] is AbseilLibraries list entry. // [absl-library] is AbseilLibraries list entry.
StringRef Path = FileEntry->getName(); StringRef Path = FileEntry->getName();
static constexpr llvm::StringLiteral AbslPrefix("absl/"); static constexpr llvm::StringLiteral AbslPrefix("absl/");
size_t PrefixPosition = Path.find(AbslPrefix); size_t PrefixPosition = Path.find(AbslPrefix);
if (PrefixPosition == StringRef::npos) if (PrefixPosition == StringRef::npos)
return false; return false;
Path = Path.drop_front(PrefixPosition + AbslPrefix.size()); Path = Path.drop_front(PrefixPosition + AbslPrefix.size());
static const char *AbseilLibraries[] = {"algorithm", "base", static const char *AbseilLibraries[] = {
"container", "debugging", "algorithm", "base", "container", "debugging", "flags",
"flags", "hash", "hash", "iterator", "memory", "meta", "numeric",
"iterator", "memory", "profiling", "random", "status", "strings", "synchronization",
"meta", "numeric", "time", "types", "utility"};
"random", "status",
"strings", "synchronization",
"time", "types",
"utility"};
return llvm::any_of(AbseilLibraries, [&](const char *Library) { return llvm::any_of(AbseilLibraries, [&](const char *Library) {
return Path.startswith(Library); return Path.startswith(Library);
}); });
} }
} // namespace ast_matchers } // namespace ast_matchers
} // namespace clang } // namespace clang