User Details
- User Since
- Aug 15 2020, 3:07 PM (92 w, 2 d)
Today
Pinging the reviewers again!
Sat, May 21
Can you take a look at the failed test?
Fri, May 13
Pinging the reviewers!
Thu, May 5
Pinging the reviewers!
Wed, Apr 27
Change block_size to enum.
Drop inline for __block_size
Move block_size to detail namespace
Include bits for libcpp_* functions.
Previous diff failed to apply. So uploading a new one.
Changes to address reviewer comments.
Apr 22 2022
Ping!
Apr 11 2022
Updated performance numbers:
Apr 8 2022
Rebase
Address review comments.
Rebased since the small sort diff got submitted.
Apr 5 2022
Minor comments, otherwise looks good to me.
Folks, this is a formatting only change to enable further changes. Please take a look.
Apr 1 2022
Fix a badly resolved merge.
Rebase
Rebase
Mar 31 2022
This diff is based on https://reviews.llvm.org/D93233. We have other changes there (updates to fixed length sorting functions, bitonic sort) that we might consider later.
Dec 13 2021
Dec 12 2021
Dec 3 2021
Louis, can you commit this for me?
Looks fine to me.
Dec 2 2021
Nov 19 2021
Nov 18 2021
Nov 17 2021
So I was writiing https://reviews.llvm.org/D114135 in parallel. I have added a test which fails with out the change. I am wondering if we should add it. Error message from the failed test below:
Can you explain when do we need to use _Comp_ref? Why is adding _Compare sufficient?
Nov 16 2021
Nov 15 2021
Pinging @ldionne.
Nov 9 2021
Move the depth check after the initial switch so that small sized sorts are not affected by the depth check.
Another attempt at uploading changes without formatting diff.
Remove formatting diffs from the diff. It seems Phabricator is unable to show the diffs between different commits.
Moved the diffs due to formatting by arc to a separate commit.
Nov 8 2021
ldionne@, I am going to break this change into few parts and provide the benchmark results for each of the part separately. To begin with, I have posted: https://reviews.llvm.org/D113413 that makes the introsort change to the std::sort implementation.
Nov 3 2021
Fixed some compilation issues and reduced the number of changes in ordering of equivalent elements
Nov 1 2021
Hi ldionne@, I have question for you. Do the tests we have for libc++ ensure that the new implementation works well across all versions of the C++ standard? I want to make sure that I am not going to unintentionally break someone's standard-compliant code out there.
Oct 13 2021
Oct 12 2021
It seems that we can use _LIBCPP_HIDE_FROM_ABI with __bitsetsort_loop. Causes the compiler to report errors like the following:
- Fixed the implementation. No tests fail now: https://buildkite.com/llvm-project/libcxx-ci/builds/5917.
- Added _LIBCPP_HIDE_FROM_ABI to most functions.
Oct 7 2021
Sep 9 2021
ymandel@, I do not have commit access to the repo. Can you commit this for me? Thanks!