User Details
- User Since
- Aug 15 2020, 3:07 PM (145 w, 4 d)
Mar 20 2023
Mar 6 2023
Addressed review comments.
Mar 5 2023
Addressed review comments.
Addressed review comments.
Mar 1 2023
Pinging reviewers!
Feb 26 2023
Removed #include <iostream> as it is not required.
Updated the test used for testing the complexity of heap sort implementation.
Feb 21 2023
Dec 22 2022
Rebase to HEAD
Dec 21 2022
Rebase to head
Dec 19 2022
@ldionne : this diff is ready for submission. If you could do so, that would be great.
Rebase to HEAD
Dec 7 2022
Corrected errors pointed out by the CI
Properly update the diff
Changed more std::move to _Ops::__iter_move
Dec 6 2022
Changed to use _Ops::__iter_move instead of std::move.
Dec 5 2022
Rebase to the HEAD revision
Dec 1 2022
I would next rebase this change and redo the internal testing I did previously. Would post the rebased diff soon.
Nov 28 2022
@ldionne : thanks for the accepting the change. We are trying to evaluate the effect of the change on Android APK's size. You might recall there were several comments about increased APK size in https://reviews.llvm.org/D113413 after it was submitted. I think it would be better if we are aware of the change in APK's size beforehand.
Nov 11 2022
Oct 31 2022
Pinging @ldionne. Can you comment on the data that would help you to make the decision? I am trying to convince folks at Google on trying out this diff. The main question being asked is what data you would like to see?
Oct 19 2022
Oct 13 2022
Jul 15 2022
Jul 6 2022
Jul 5 2022
Jun 14 2022
Pinging the reviewers!
May 25 2022
May 23 2022
Pinging the reviewers again!
May 21 2022
Can you take a look at the failed test?
May 13 2022
Pinging the reviewers!
May 5 2022
Pinging the reviewers!
Apr 27 2022
Change block_size to enum.
Drop inline for __block_size
Move block_size to detail namespace
Include bits for libcpp_* functions.
Previous diff failed to apply. So uploading a new one.
Changes to address reviewer comments.
Apr 22 2022
Ping!
Apr 11 2022
Updated performance numbers:
Apr 8 2022
Rebase
Address review comments.
Rebased since the small sort diff got submitted.
Apr 5 2022
Minor comments, otherwise looks good to me.
Folks, this is a formatting only change to enable further changes. Please take a look.
Apr 1 2022
Fix a badly resolved merge.
Rebase
Rebase
Mar 31 2022
This diff is based on https://reviews.llvm.org/D93233. We have other changes there (updates to fixed length sorting functions, bitonic sort) that we might consider later.
Dec 13 2021
Dec 12 2021
Dec 3 2021
Louis, can you commit this for me?
Looks fine to me.
Dec 2 2021
Nov 19 2021
Nov 18 2021
Nov 17 2021
So I was writiing https://reviews.llvm.org/D114135 in parallel. I have added a test which fails with out the change. I am wondering if we should add it. Error message from the failed test below:
Can you explain when do we need to use _Comp_ref? Why is adding _Compare sufficient?
Nov 16 2021
Nov 15 2021
Pinging @ldionne.
Nov 9 2021
Move the depth check after the initial switch so that small sized sorts are not affected by the depth check.
Another attempt at uploading changes without formatting diff.
Remove formatting diffs from the diff. It seems Phabricator is unable to show the diffs between different commits.
Moved the diffs due to formatting by arc to a separate commit.
Nov 8 2021
ldionne@, I am going to break this change into few parts and provide the benchmark results for each of the part separately. To begin with, I have posted: https://reviews.llvm.org/D113413 that makes the introsort change to the std::sort implementation.